admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix reporting of metrics when there is no video in the test.

Browse Source 
Before if there is no video in PC quality test video quaity analyzer
failed on RTC_CHECK becuase of empty counter. Now it will report no
metrics and print 0 in debug logging.

Bug: webrtc:10138
Change-Id: If6656a613465c522cac1d4b2e4dd455e409229ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133886
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27731}
This commit is contained in:
Artem Titov 2019-04-23 16:33:38 +02:00 committed by Commit Bot
parent e1068c1bc9
commit 7e2f6b7d92
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc
View File

@ -492,11 +492,13 @@ void DefaultVideoQualityAnalyzer::ReportResults() {
LogFrameCounters(item.first, stream_frame_counters_.at(item.first));
LogStreamInternalStats(item.first, item.second);
}
RTC_LOG(INFO) << "comparisons_queue_size min="
<< analyzer_stats_.comparisons_queue_size.GetMin()
<< "; max=" << analyzer_stats_.comparisons_queue_size.GetMax()
<< "; 99%="
<< analyzer_stats_.comparisons_queue_size.GetPercentile(0.99);
if (!analyzer_stats_.comparisons_queue_size.IsEmpty()) {
RTC_LOG(INFO) << "comparisons_queue_size min="
<< analyzer_stats_.comparisons_queue_size.GetMin()
<< "; max=" << analyzer_stats_.comparisons_queue_size.GetMax()
<< "; 99%="
<< analyzer_stats_.comparisons_queue_size.GetPercentile(0.99);
}
RTC_LOG(INFO) << "comparisons_done=" << analyzer_stats_.comparisons_done;
RTC_LOG(INFO) << "overloaded_comparisons_done="
<< analyzer_stats_.overloaded_comparisons_done;