admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add Performance::encode_on_calling_thread flag.

Browse Source 
Bug: b/336978562
Change-Id: Id6edf45e80efb99ace46299ef36082f280cb8921
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350622
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42311}
This commit is contained in:
philipel 2024-05-15 14:07:03 +02:00 committed by WebRTC LUCI CQ
parent f9da667dca
commit 7db2a85697
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
api/video_codecs/libaom_av1_encoder_factory.cc
View File

@ -810,11 +810,13 @@ std::map<std::string, std::string> LibaomAv1EncoderFactory::CodecSpecifics()
return {};
}
// clang-format off
// The formater and cpplint have conflicting ideas.
VideoEncoderFactoryInterface::Capabilities
LibaomAv1EncoderFactory::GetEncoderCapabilities() const {
return {
.prediction_constraints =
{.num_buffers = kNumBuffers,
.prediction_constraints = {
.num_buffers = kNumBuffers,
.max_references = kMaxReferences,
.max_temporal_layers = kMaxTemporalLayers,
.buffer_space_type = VideoEncoderFactoryInterface::Capabilities::
@ -834,14 +836,16 @@ LibaomAv1EncoderFactory::GetEncoderCapabilities() const {
},
.encoding_formats = {{.sub_sampling = EncodingFormat::k420,
.bit_depth = 8}},
.rate_control =
{.qp_range = {0, kMaxQp},
.rate_control = {
.qp_range = {0, kMaxQp},
.rc_modes = {VideoEncoderFactoryInterface::RateControlMode::kCbr,
VideoEncoderFactoryInterface::RateControlMode::kCqp}},
.performance = {.min_max_effort_level = {kMinEffortLevel,
.performance = {.encode_on_calling_thread = true,
.min_max_effort_level = {kMinEffortLevel,
kMaxEffortLevel}},
};
}
// clang-format on
std::unique_ptr<VideoEncoderInterface> LibaomAv1EncoderFactory::CreateEncoder(
const StaticEncoderSettings& settings,

1
api/video_codecs/video_encoder_factory_interface.h
View File

@ -70,6 +70,7 @@ class VideoEncoderFactoryInterface {
} rate_control;
struct Performance {
bool encode_on_calling_thread;
std::pair<int, int> min_max_effort_level;
} performance;
};