From 7d984ee1d7cb592efd5174f88effa6ba4a79b0f9 Mon Sep 17 00:00:00 2001 From: Oleh Prypin Date: Fri, 3 Aug 2018 00:03:17 +0200 Subject: [PATCH] Don't allocate an array of size 0, it causes a UBSan failure Bug: webrtc:9587 Change-Id: I56bdf3c5c8744044b2d0d1fa3531fca504ea200f Reviewed-on: https://webrtc-review.googlesource.com/92091 Reviewed-by: Harald Alvestrand Commit-Queue: Oleh Prypin Cr-Commit-Position: refs/heads/master@{#24178} --- rtc_base/buffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtc_base/buffer.h b/rtc_base/buffer.h index 64974d3ed9..22f89372de 100644 --- a/rtc_base/buffer.h +++ b/rtc_base/buffer.h @@ -87,7 +87,7 @@ class BufferT { BufferT(size_t size, size_t capacity) : size_(size), capacity_(std::max(size, capacity)), - data_(new T[capacity_]) { + data_(capacity_ > 0 ? new T[capacity_] : nullptr) { RTC_DCHECK(IsConsistent()); }