From 7bf536976366443ea59153ff3d22da0ec32badc1 Mon Sep 17 00:00:00 2001 From: hbos Date: Thu, 15 Dec 2016 03:33:35 -0800 Subject: [PATCH] RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs. This makes sure that the referenced stats dictionaries exist. BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2577033002 Cr-Commit-Position: refs/heads/master@{#15628} --- webrtc/api/rtcstats_integrationtest.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/webrtc/api/rtcstats_integrationtest.cc b/webrtc/api/rtcstats_integrationtest.cc index 0f60377eb2..9600f2a5d0 100644 --- a/webrtc/api/rtcstats_integrationtest.cc +++ b/webrtc/api/rtcstats_integrationtest.cc @@ -450,7 +450,7 @@ class RTCStatsReportVerifier { verifier->TestMemberIsUndefined(stream.media_track_id); verifier->TestMemberIsIDReference( stream.transport_id, RTCTransportStats::kType); - verifier->TestMemberIsDefined(stream.codec_id); + verifier->TestMemberIsIDReference(stream.codec_id, RTCCodecStats::kType); if (stream.media_type.is_defined() && *stream.media_type == "video") { verifier->TestMemberIsDefined(stream.fir_count); verifier->TestMemberIsDefined(stream.pli_count); @@ -510,9 +510,12 @@ class RTCStatsReportVerifier { verifier.TestMemberIsOptionalIDReference( transport.rtcp_transport_stats_id, RTCTransportStats::kType); verifier.TestMemberIsDefined(transport.active_connection); - verifier.TestMemberIsDefined(transport.selected_candidate_pair_id); - verifier.TestMemberIsDefined(transport.local_certificate_id); - verifier.TestMemberIsDefined(transport.remote_certificate_id); + verifier.TestMemberIsIDReference( + transport.selected_candidate_pair_id, RTCIceCandidatePairStats::kType); + verifier.TestMemberIsIDReference( + transport.local_certificate_id, RTCCertificateStats::kType); + verifier.TestMemberIsIDReference( + transport.remote_certificate_id, RTCCertificateStats::kType); return verifier.ExpectAllMembersSuccessfullyTested(); }