admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Avoid calling OnRoundTripTimeUpdate with invalid RTTs."

Browse Source 
This reverts commit afa61c94e50e2737d4d4b22d7a830845e763cf27.

Reason for revert: Breaks a downstream test.

Original change's description:
> Avoid calling OnRoundTripTimeUpdate with invalid RTTs.
> 
> Bug: none
> Change-Id: Ic19b87ad7094465da6091d0e99b10a6d1b7d2e58
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128776
> Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27308}

TBR=srte@webrtc.org,crodbro@webrtc.org

Change-Id: Ic4c516d3325050858ac99731f6d25181fb40b7bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129922
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27309}
This commit is contained in:
Christoffer Rodbro 2019-03-27 12:52:33 +00:00 committed by Commit Bot
parent afa61c94e5
commit 7b6acd68ee
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
call/rtp_transport_controller_send.cc
View File

@ -400,7 +400,7 @@ void RtpTransportControllerSend::OnReceivedRtcpReceiverReport(
report.receive_time = Timestamp::ms(now_ms);
report.round_trip_time = TimeDelta::ms(rtt_ms);
report.smoothed = false;
if (controller_ && !report.round_trip_time.IsZero())
if (controller_)
PostUpdates(controller_->OnRoundTripTimeUpdate(report));
});
}

1
modules/congestion_controller/goog_cc/goog_cc_network_control.cc
View File

@ -229,7 +229,6 @@ NetworkControlUpdate GoogCcNetworkController::OnRoundTripTimeUpdate(
RoundTripTimeUpdate msg) {
if (packet_feedback_only_ || msg.smoothed)
return NetworkControlUpdate();
RTC_DCHECK(!msg.round_trip_time.IsZero());
if (delay_based_bwe_)
delay_based_bwe_->OnRttUpdate(msg.round_trip_time);
bandwidth_estimation_->UpdateRtt(msg.round_trip_time, msg.receive_time);