From 7b4b39809fa9f4a9410da5f9d6c6626e7fbbcbcd Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Wed, 6 Dec 2023 17:55:07 +0000 Subject: [PATCH] Remove DCHECK when transport feedback on request can't be produced Bug: chromium:1507210 Change-Id: I840b91dd7143ce6a0d3c9a17df6c187e01a145f9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330320 Reviewed-by: Per Kjellander Commit-Queue: Per Kjellander Cr-Commit-Position: refs/heads/main@{#41351} --- .../remote_estimator_proxy.cc | 7 +++++-- test/fuzzers/BUILD.gn | 1 + .../receive-side-cc/testcase-5414098152390656 | Bin 0 -> 87 bytes 3 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 test/fuzzers/corpora/receive-side-cc/testcase-5414098152390656 diff --git a/modules/remote_bitrate_estimator/remote_estimator_proxy.cc b/modules/remote_bitrate_estimator/remote_estimator_proxy.cc index e100995b8e..6953ec8400 100644 --- a/modules/remote_bitrate_estimator/remote_estimator_proxy.cc +++ b/modules/remote_bitrate_estimator/remote_estimator_proxy.cc @@ -260,8 +260,11 @@ void RemoteEstimatorProxy::SendFeedbackOnRequest( feedback_request.include_timestamps, first_sequence_number, sequence_number + 1, /*is_periodic_update=*/false); - // This is called when a packet has just been added. - RTC_DCHECK(feedback_packet != nullptr); + // Even though this is called when a packet has just been added, + // no feedback may be produced when that new packet is too old. + if (feedback_packet == nullptr) { + return; + } // Clear up to the first packet that is included in this feedback packet. packet_arrival_times_.EraseTo(first_sequence_number); diff --git a/test/fuzzers/BUILD.gn b/test/fuzzers/BUILD.gn index 43e9a5e922..4384c315b9 100644 --- a/test/fuzzers/BUILD.gn +++ b/test/fuzzers/BUILD.gn @@ -248,6 +248,7 @@ webrtc_fuzzer_test("receive_side_congestion_controller_fuzzer") { "../../modules/rtp_rtcp:rtp_rtcp_format", "../../system_wrappers", ] + seed_corpus = "corpora/receive-side-cc" } rtc_library("audio_decoder_fuzzer") { diff --git a/test/fuzzers/corpora/receive-side-cc/testcase-5414098152390656 b/test/fuzzers/corpora/receive-side-cc/testcase-5414098152390656 new file mode 100644 index 0000000000000000000000000000000000000000..98c423cdc2910c7d34e2a7a7b3f58bea119e96fc GIT binary patch literal 87 zcmYe^&OAY6