From 7b4b29a13f94241f4bb1e7821d069a63f9ffc459 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 29 Nov 2023 16:01:38 +0000 Subject: [PATCH] Disable cpplint readability/todo. This check triggers on new style TODOs (TODO: BUG - TEXT). The fix should land in the upstream cpplint, on the other hand this check is disbled in Chromium as well. WebRTC should disable for the same reasons [1]. [1] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/depot_tools/presubmit_canned_checks.py;l=48-54;drc=f2f8be1ca848f99de85fd299af537a2e2a462387 Bug: b/299058717 Change-Id: I3f56c92663d02dcb323d74870ed72025ae8e02e4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329161 Reviewed-by: Danil Chapovalov Reviewed-by: Harald Alvestrand Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#41280} --- PRESUBMIT.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 2d9768f86a..e5f28b70d1 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -59,12 +59,15 @@ PYLINT_OLD_STYLE = [ # - build/c++11 : Rvalue ref checks are unreliable (false positives), # include file and feature blocklists are # google3-specific. +# - readability/todo : WebRTC puts bug links, not usernames, in TODOs. +# The new TODO style also doesn't match with this check. # - runtime/references : Mutable references are not banned by the Google # C++ style guide anymore (starting from May 2020). # - whitespace/operators: Same as above (doesn't seem sufficient to eliminate # all move-related errors). DISABLED_LINT_FILTERS = [ '-build/c++11', + '-readability/todo', '-runtime/references', '-whitespace/operators', ]