From 7b3eca9940e4e9407df2024248a212063680b6d6 Mon Sep 17 00:00:00 2001 From: VladimirTechMan Date: Wed, 31 May 2017 18:25:48 -0700 Subject: [PATCH] Add media constraint-key constants for generating offers and answers Similar to the existing constants for the media constraint-keys intended for media sources, add the constants for the standard keys to generate offers and answers. This patch also adds a few comments to RTCMediaConstraints.h, to give a better clue on the intended usage scope of declared media-constraint keys and values. BUG=webrtc:7722 Review-Url: https://codereview.webrtc.org/2908013002 Cr-Commit-Position: refs/heads/master@{#18362} --- .../Classes/PeerConnection/RTCMediaConstraints.mm | 9 +++++++++ .../objc/Framework/Headers/WebRTC/RTCMediaConstraints.h | 8 ++++++++ 2 files changed, 17 insertions(+) diff --git a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCMediaConstraints.mm b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCMediaConstraints.mm index 3b9d845841..c686b5643c 100644 --- a/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCMediaConstraints.mm +++ b/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCMediaConstraints.mm @@ -35,6 +35,15 @@ NSString * const kRTCMediaConstraintsLevelControl = NSString * const kRTCMediaConstraintsAudioNetworkAdaptorConfig = @(webrtc::MediaConstraintsInterface::kAudioNetworkAdaptorConfig); +NSString * const kRTCMediaConstraintsIceRestart = + @(webrtc::MediaConstraintsInterface::kIceRestart); +NSString * const kRTCMediaConstraintsOfferToReceiveAudio = + @(webrtc::MediaConstraintsInterface::kOfferToReceiveAudio); +NSString * const kRTCMediaConstraintsOfferToReceiveVideo = + @(webrtc::MediaConstraintsInterface::kOfferToReceiveVideo); +NSString * const kRTCMediaConstraintsVoiceActivityDetection = + @(webrtc::MediaConstraintsInterface::kVoiceActivityDetection); + NSString * const kRTCMediaConstraintsValueTrue = @(webrtc::MediaConstraintsInterface::kValueTrue); NSString * const kRTCMediaConstraintsValueFalse = diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h index d57231542d..26a116888a 100644 --- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h +++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h @@ -14,6 +14,7 @@ NS_ASSUME_NONNULL_BEGIN +/** Constraint keys for media sources. */ RTC_EXTERN NSString * const kRTCMediaConstraintsMinAspectRatio; RTC_EXTERN NSString * const kRTCMediaConstraintsMaxAspectRatio; RTC_EXTERN NSString * const kRTCMediaConstraintsMaxWidth; @@ -28,6 +29,13 @@ RTC_EXTERN NSString * const kRTCMediaConstraintsLevelControl; */ RTC_EXTERN NSString * const kRTCMediaConstraintsAudioNetworkAdaptorConfig; +/** Constraint keys for generating offers and answers. */ +RTC_EXTERN NSString * const kRTCMediaConstraintsIceRestart; +RTC_EXTERN NSString * const kRTCMediaConstraintsOfferToReceiveAudio; +RTC_EXTERN NSString * const kRTCMediaConstraintsOfferToReceiveVideo; +RTC_EXTERN NSString * const kRTCMediaConstraintsVoiceActivityDetection; + +/** Constraint values for Boolean parameters. */ RTC_EXTERN NSString * const kRTCMediaConstraintsValueTrue; RTC_EXTERN NSString * const kRTCMediaConstraintsValueFalse;