admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove dead code in offer/answer handling

Browse Source 
the ssrc-group consistency is checked by the media engine.

BUG=chromium:1454860

Change-Id: Ib9f60a0e773ffd1810aae4e5f464d12619e94b5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311160
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40389}
This commit is contained in:
Philipp Hancke 2023-07-01 09:47:34 +02:00 committed by WebRTC LUCI CQ
parent d51dada719
commit 7a35f108c7
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pc/sdp_offer_answer.cc
View File

@ -491,25 +491,6 @@ RTCError ValidateBundledPayloadTypes(
return RTCError::OK();
}
RTCError ValidateSsrcGroups(const cricket::SessionDescription& description) {
// https://www.rfc-editor.org/rfc/rfc5576#section-4.2
// Every <ssrc-id> listed in an "ssrc-group" attribute MUST be
// defined by a corresponding "ssrc:" line in the same media
// description.
for (const ContentInfo& content : description.contents()) {
if (!content.media_description()) {
continue;
}
for (const StreamParams& sp : content.media_description()->streams()) {
for (const cricket::SsrcGroup& group : sp.ssrc_groups) {
RTC_LOG(LS_ERROR) << "YO " << group.semantics << " #"
<< group.ssrcs.size();
}
}
}
return RTCError::OK();
}
RTCError FindDuplicateHeaderExtensionIds(
const RtpExtension extension,
std::map<int, RtpExtension>& id_to_extension) {
@ -3586,11 +3567,6 @@ RTCError SdpOfferAnswerHandler::ValidateSessionDescription(
return RTCError(RTCErrorType::INVALID_PARAMETER, kBundleWithoutRtcpMux);
}
error = ValidateSsrcGroups(*sdesc->description());
if (!error.ok()) {
return error;
}
// TODO(skvlad): When the local rtcp-mux policy is Require, reject any
// m-lines that do not rtcp-mux enabled.