diff --git a/modules/video_coding/codecs/vp8/include/vp8.h b/modules/video_coding/codecs/vp8/include/vp8.h index 625e5acf91..e86d758b36 100644 --- a/modules/video_coding/codecs/vp8/include/vp8.h +++ b/modules/video_coding/codecs/vp8/include/vp8.h @@ -17,18 +17,11 @@ #include "absl/base/nullability.h" #include "api/environment/environment.h" #include "api/video_codecs/video_encoder.h" -#include "api/video_codecs/vp8_frame_buffer_controller.h" #include "modules/video_coding/include/video_codec_interface.h" namespace webrtc { struct Vp8EncoderSettings { - // Allows for overriding the Vp8FrameBufferController used by the encoder. - // If unset, a default Vp8FrameBufferController will be instantiated - // internally. - absl::Nullable> - frame_buffer_controller_factory; - // Allows for overriding the resolution/bitrate limits exposed through // VideoEncoder::GetEncoderInfo(). No override is done if empty. std::vector resolution_bitrate_limits; diff --git a/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc b/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc index a6befaf33b..3af0bdfa90 100644 --- a/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc +++ b/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc @@ -314,8 +314,6 @@ LibvpxVp8Encoder::LibvpxVp8Encoder(std::unique_ptr interface, VP8Encoder::Settings settings) : libvpx_(std::move(interface)), rate_control_settings_(RateControlSettings::ParseFromFieldTrials()), - frame_buffer_controller_factory_( - std::move(settings.frame_buffer_controller_factory)), resolution_bitrate_limits_(std::move(settings.resolution_bitrate_limits)), key_frame_request_(kMaxSimulcastStreams, false), last_encoder_output_time_(kMaxSimulcastStreams, @@ -537,14 +535,9 @@ int LibvpxVp8Encoder::InitEncode(const VideoCodec* inst, } RTC_DCHECK(!frame_buffer_controller_); - if (frame_buffer_controller_factory_) { - frame_buffer_controller_ = frame_buffer_controller_factory_->Create( - *inst, settings, fec_controller_override_); - } else { - Vp8TemporalLayersFactory factory; - frame_buffer_controller_ = - factory.Create(*inst, settings, fec_controller_override_); - } + Vp8TemporalLayersFactory factory; + frame_buffer_controller_ = + factory.Create(*inst, settings, fec_controller_override_); RTC_DCHECK(frame_buffer_controller_); number_of_cores_ = settings.number_of_cores; diff --git a/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.h b/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.h index 3d9dca7cca..989ce5ea2b 100644 --- a/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.h +++ b/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.h @@ -129,8 +129,6 @@ class LibvpxVp8Encoder : public VideoEncoder { int number_of_cores_ = 0; uint32_t rc_max_intra_target_ = 0; int num_active_streams_ = 0; - const std::unique_ptr - frame_buffer_controller_factory_; std::unique_ptr frame_buffer_controller_; const std::vector resolution_bitrate_limits_;