admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize RenderBuffer.

Browse Source 
Changing to an index for-loop (instead of using std::transform) allows the compiler (clang for x86 at least) to use 3 different registers in the loop rather than just 1, resulting in less pipeline stall (I'd assume). Interestingly, the compiler unrolls the loop(s) completely in both cases.

Bug: None
Change-Id: I586773bc525e91bb6eb6638d5399928482306b9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239364
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Christian Schuldt <cschuldt@google.com>
Cr-Commit-Position: refs/heads/main@{#35453}
This commit is contained in:
cschuldt 2021-11-29 16:56:37 +01:00 committed by WebRTC LUCI CQ
parent 59b8a46d3f
commit 794cc227dc
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
modules/audio_processing/aec3/render_buffer.cc
View File

@ -42,8 +42,9 @@ void RenderBuffer::SpectralSum(
int position = spectrum_buffer_->read; int position = spectrum_buffer_->read;
for (size_t j = 0; j < num_spectra; ++j) { for (size_t j = 0; j < num_spectra; ++j) {
for (const auto& channel_spectrum : spectrum_buffer_->buffer[position]) { for (const auto& channel_spectrum : spectrum_buffer_->buffer[position]) {
std::transform(X2->begin(), X2->end(), channel_spectrum.begin(), for (size_t k = 0; k < X2->size(); ++k) {
X2->begin(), std::plus<float>()); (*X2)[k] += channel_spectrum[k];
}
} }
position = spectrum_buffer_->IncIndex(position); position = spectrum_buffer_->IncIndex(position);
} }
@ -60,18 +61,18 @@ void RenderBuffer::SpectralSums(
size_t j = 0; size_t j = 0;
for (; j < num_spectra_shorter; ++j) { for (; j < num_spectra_shorter; ++j) {
for (const auto& channel_spectrum : spectrum_buffer_->buffer[position]) { for (const auto& channel_spectrum : spectrum_buffer_->buffer[position]) {
std::transform(X2_shorter->begin(), X2_shorter->end(), for (size_t k = 0; k < X2_shorter->size(); ++k) {
channel_spectrum.begin(), X2_shorter->begin(), (*X2_shorter)[k] += channel_spectrum[k];
std::plus<float>()); }
} }
position = spectrum_buffer_->IncIndex(position); position = spectrum_buffer_->IncIndex(position);
} }
std::copy(X2_shorter->begin(), X2_shorter->end(), X2_longer->begin()); std::copy(X2_shorter->begin(), X2_shorter->end(), X2_longer->begin());
for (; j < num_spectra_longer; ++j) { for (; j < num_spectra_longer; ++j) {
for (const auto& channel_spectrum : spectrum_buffer_->buffer[position]) { for (const auto& channel_spectrum : spectrum_buffer_->buffer[position]) {
std::transform(X2_longer->begin(), X2_longer->end(), for (size_t k = 0; k < X2_longer->size(); ++k) {
channel_spectrum.begin(), X2_longer->begin(), (*X2_longer)[k] += channel_spectrum[k];
std::plus<float>()); }
} }
position = spectrum_buffer_->IncIndex(position); position = spectrum_buffer_->IncIndex(position);
} }