admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ValidateMessageIntegrity standalone functions

Browse Source 
These functions have been deprecated since October 2022.

Bug: None
Change-Id: I74f51c9d0e8ee340a2043bf43f7a1b0d8b79726e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364280
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43118}
This commit is contained in:
Harald Alvestrand 2024-09-30 21:50:15 +00:00 committed by WebRTC LUCI CQ
parent 8569a0d534
commit 789a54a0c4
2 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
api/transport/stun.cc
View File

@ -366,24 +366,6 @@ bool StunMessage::ValidateMessageIntegrity32ForTesting(
password); password);
} }
// Deprecated
bool StunMessage::ValidateMessageIntegrity(const char* data,
size_t size,
const std::string& password) {
return ValidateMessageIntegrityOfType(STUN_ATTR_MESSAGE_INTEGRITY,
kStunMessageIntegritySize, data, size,
password);
}
// Deprecated
bool StunMessage::ValidateMessageIntegrity32(const char* data,
size_t size,
const std::string& password) {
return ValidateMessageIntegrityOfType(STUN_ATTR_GOOG_MESSAGE_INTEGRITY_32,
kStunMessageIntegrity32Size, data, size,
password);
}
// Verifies a STUN message has a valid MESSAGE-INTEGRITY attribute, using the // Verifies a STUN message has a valid MESSAGE-INTEGRITY attribute, using the
// procedure outlined in RFC 5389, section 15.4. // procedure outlined in RFC 5389, section 15.4.
bool StunMessage::ValidateMessageIntegrityOfType(int mi_attr_type, bool StunMessage::ValidateMessageIntegrityOfType(int mi_attr_type,

13
api/transport/stun.h
View File

@ -294,19 +294,6 @@ class StunMessage {
bool EqualAttributes(const StunMessage* other, bool EqualAttributes(const StunMessage* other,
std::function<bool(int type)> attribute_type_mask) const; std::function<bool(int type)> attribute_type_mask) const;
// Validates that a STUN message in byte buffer form
// has a correct MESSAGE-INTEGRITY value.
// These functions are not recommended and will be deprecated; use
// ValidateMessageIntegrity(password) on the parsed form instead.
[[deprecated("Use member function")]] static bool ValidateMessageIntegrity(
const char* data,
size_t size,
const std::string& password);
[[deprecated("Use member function")]] static bool ValidateMessageIntegrity32(
const char* data,
size_t size,
const std::string& password);
// Expose raw-buffer ValidateMessageIntegrity function for testing. // Expose raw-buffer ValidateMessageIntegrity function for testing.
static bool ValidateMessageIntegrityForTesting(const char* data, static bool ValidateMessageIntegrityForTesting(const char* data,
size_t size, size_t size,