From 78417cf7c0e1ed41e2b65f72df147b3f5b01992f Mon Sep 17 00:00:00 2001 From: perkj Date: Fri, 4 Mar 2016 03:09:14 -0800 Subject: [PATCH] Fix VideoTrack VideoSinkWants for renderers. This temporarily fixes a probem where renderers causes VideoSinkWants.rotation_applied=true. The problem was introduced by https://codereview.webrtc.org/1759473003/ where VideTrackRenderes are registered to the cricket::VideoCapturer with default VideoSinkWants. BUG=webrtc:5621 Review URL: https://codereview.webrtc.org/1764693004 Cr-Commit-Position: refs/heads/master@{#11871} --- webrtc/api/videotrack.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/webrtc/api/videotrack.cc b/webrtc/api/videotrack.cc index b776509930..0f933a0dab 100644 --- a/webrtc/api/videotrack.cc +++ b/webrtc/api/videotrack.cc @@ -20,8 +20,14 @@ VideoTrack::VideoTrack(const std::string& label, VideoSourceInterface* video_source) : MediaStreamTrack(label), video_source_(video_source) { + // TODO(perkj): Sinks should register directly to the source so that + // VideoSinkWants can be applied correctly per sink. For now, |renderers_| + // must be able to apply rotation. Note that this is only actual renderers, + // not sinks that connect directly to cricket::VideoCapture. + rtc::VideoSinkWants wants; + wants.rotation_applied = false; if (video_source_) - video_source_->AddOrUpdateSink(&renderers_, rtc::VideoSinkWants()); + video_source_->AddOrUpdateSink(&renderers_, wants); } VideoTrack::~VideoTrack() {