From 78416b6e1851f86a2091b0e06bb906731faa98e5 Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Thu, 18 Oct 2018 13:08:17 +0200 Subject: [PATCH] Adds time to initial config in analyzer code. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:9586 Change-Id: Ib5cbcdcf2cce3bea24d8c03a25f6cd415feb97ad Reviewed-on: https://webrtc-review.googlesource.com/c/106880 Reviewed-by: Björn Terelius Commit-Queue: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#25254} --- modules/congestion_controller/goog_cc/goog_cc_network_control.cc | 1 + rtc_tools/event_log_visualizer/analyzer.cc | 1 + 2 files changed, 2 insertions(+) diff --git a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc index efd78b4170..6e4774d167 100644 --- a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc +++ b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc @@ -156,6 +156,7 @@ GoogCcNetworkController::GoogCcNetworkController(RtcEventLog* event_log, max_total_allocated_bitrate_(DataRate::Zero()), in_cwnd_experiment_(CwndExperimentEnabled()), accepted_queue_ms_(kDefaultAcceptedQueueMs) { + RTC_DCHECK(config.constraints.at_time.IsFinite()); delay_based_bwe_->SetMinBitrate(congestion_controller::GetMinBitrateBps()); if (in_cwnd_experiment_ && !ReadCwndExperimentParameter(&accepted_queue_ms_)) { diff --git a/rtc_tools/event_log_visualizer/analyzer.cc b/rtc_tools/event_log_visualizer/analyzer.cc index 74acd62b58..b1a9734827 100644 --- a/rtc_tools/event_log_visualizer/analyzer.cc +++ b/rtc_tools/event_log_visualizer/analyzer.cc @@ -1087,6 +1087,7 @@ void EventLogAnalyzer::CreateSendSideBweSimulationGraph(Plot* plot) { // TODO(holmer): Log the call config and use that here instead. static const uint32_t kDefaultStartBitrateBps = 300000; NetworkControllerConfig cc_config; + cc_config.constraints.at_time = Timestamp::us(clock.TimeInMicroseconds()); cc_config.constraints.starting_rate = DataRate::bps(kDefaultStartBitrateBps); auto goog_cc = factory.Create(cc_config);