From 775ce76b66c323ad853c867144339adaa547e535 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Tue, 8 Mar 2022 14:11:36 +0100 Subject: [PATCH] Don't swallow UnsatisfiedLinkError MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When loading the library fails, the user will be faced with this error: java.lang.UnsatisfiedLinkError: No implementation found for void org.webrtc.PeerConnectionFactory.nativeInitializeAndroidGlobals() With no context, however. Bug: webrtc:13619 Change-Id: I88565f085773ad1e8c2f5742d7fdba96fb6043d8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253960 Reviewed-by: Christoffer Jansson Reviewed-by: Xavier Lepaul‎ Commit-Queue: Xavier Lepaul‎ Cr-Commit-Position: refs/heads/main@{#36150} --- sdk/android/src/java/org/webrtc/NativeLibrary.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sdk/android/src/java/org/webrtc/NativeLibrary.java b/sdk/android/src/java/org/webrtc/NativeLibrary.java index 7fa5d6ff16..531c216302 100644 --- a/sdk/android/src/java/org/webrtc/NativeLibrary.java +++ b/sdk/android/src/java/org/webrtc/NativeLibrary.java @@ -17,12 +17,9 @@ class NativeLibrary { @Override public boolean load(String name) { Logging.d(TAG, "Loading library: " + name); - try { - System.loadLibrary(name); - } catch (UnsatisfiedLinkError e) { - Logging.e(TAG, "Failed to load native library: " + name, e); - return false; - } + System.loadLibrary(name); + + // Not relevant, but kept for API compatibility. return true; } }