From 7634ea7240f6171b3d3013a49eaabf791951722a Mon Sep 17 00:00:00 2001 From: Bjorn Terelius Date: Fri, 2 Oct 2020 14:53:50 +0200 Subject: [PATCH] Add method to extract triage alerts from RTC event log analyzer. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:11566 Change-Id: I8315895be4fe93513247c49452c50ec23e9d1e11 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186560 Reviewed-by: Andrey Logvin Commit-Queue: Björn Terelius Cr-Commit-Position: refs/heads/master@{#32292} --- rtc_tools/rtc_event_log_visualizer/alerts.cc | 26 +++++++++++++------- rtc_tools/rtc_event_log_visualizer/alerts.h | 2 ++ 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/rtc_tools/rtc_event_log_visualizer/alerts.cc b/rtc_tools/rtc_event_log_visualizer/alerts.cc index 86372de4cf..2d1868fa28 100644 --- a/rtc_tools/rtc_event_log_visualizer/alerts.cc +++ b/rtc_tools/rtc_event_log_visualizer/alerts.cc @@ -26,15 +26,6 @@ namespace webrtc { -void TriageHelper::Print(FILE* file) { - fprintf(file, "========== TRIAGE NOTIFICATIONS ==========\n"); - for (const auto& alert : triage_alerts_) { - fprintf(file, "%d %s. First occurrence at %3.3lf\n", alert.second.count, - alert.second.explanation.c_str(), alert.second.first_occurrence); - } - fprintf(file, "========== END TRIAGE NOTIFICATIONS ==========\n"); -} - void TriageHelper::AnalyzeStreamGaps(const ParsedRtcEventLog& parsed_log, PacketDirection direction) { // With 100 packets/s (~800kbps), false positives would require 10 s without @@ -224,4 +215,21 @@ void TriageHelper::AnalyzeLog(const ParsedRtcEventLog& parsed_log) { } } +void TriageHelper::Print(FILE* file) { + fprintf(file, "========== TRIAGE NOTIFICATIONS ==========\n"); + for (const auto& alert : triage_alerts_) { + fprintf(file, "%d %s. First occurrence at %3.3lf\n", alert.second.count, + alert.second.explanation.c_str(), alert.second.first_occurrence); + } + fprintf(file, "========== END TRIAGE NOTIFICATIONS ==========\n"); +} + +void TriageHelper::ProcessAlerts( + std::function f) { + for (const auto& alert : triage_alerts_) { + f(alert.second.count, alert.second.first_occurrence, + alert.second.explanation); + } +} + } // namespace webrtc diff --git a/rtc_tools/rtc_event_log_visualizer/alerts.h b/rtc_tools/rtc_event_log_visualizer/alerts.h index 7bd9f05270..d3e41666aa 100644 --- a/rtc_tools/rtc_event_log_visualizer/alerts.h +++ b/rtc_tools/rtc_event_log_visualizer/alerts.h @@ -57,6 +57,8 @@ class TriageHelper { PacketDirection direction); void Print(FILE* file); + void ProcessAlerts(std::function f); + private: AnalyzerConfig config_; std::map triage_alerts_;