From 73ee252245f1d8dec9a4ae0bc7fe2390d58b4fd7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Bostr=C3=B6m?= Date: Mon, 27 Jun 2022 10:28:24 +0200 Subject: [PATCH] Remove excessive log spam from receiver.getParameters(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's normal for a receiver to not be configured to receive, such as when currentDirection is not (or not yet) "sendrecv" or "recvonly". getParameters() returning an empty set of encodings is valid and these logs are not very useful. It's also inconsistent that we only log after SLD has happened due to different code paths inside getParameters(), repro: https://jsfiddle.net/henbos/xqksj3wd/. Most notably we're calling getParameters() internally from inside of getStats() which can cause excessive log spam. I prefer that we remove these logs rather than avoid calling getParameters() from inside of getStats() on non-receiving receivers since it's valid to check how many encodings exist on a receiver using getParameters(), and whether or not the SSRC has been signaled could in theory affect the number of encodings even if we do want to receive. Also an app calling getParameters() on an inactive receiver is valid and should not cause logs. Bug: webrtc:14225 Change-Id: I4290781d6aed92aa03fe0c662762aa97c99a045c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266960 Commit-Queue: Erik Språng Auto-Submit: Henrik Boström Reviewed-by: Erik Språng Commit-Queue: Henrik Boström Cr-Commit-Position: refs/heads/main@{#37335} --- media/engine/webrtc_video_engine.cc | 6 +++--- media/engine/webrtc_voice_engine.cc | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/media/engine/webrtc_video_engine.cc b/media/engine/webrtc_video_engine.cc index 561eba6e25..818ff24081 100644 --- a/media/engine/webrtc_video_engine.cc +++ b/media/engine/webrtc_video_engine.cc @@ -1157,9 +1157,9 @@ webrtc::RtpParameters WebRtcVideoChannel::GetDefaultRtpReceiveParameters() RTC_DCHECK_RUN_ON(&thread_checker_); webrtc::RtpParameters rtp_params; if (!default_unsignalled_ssrc_handler_.GetDefaultSink()) { - RTC_LOG(LS_WARNING) << "Attempting to get RTP parameters for the default, " - "unsignaled video receive stream, but not yet " - "configured to receive such a stream."; + // Getting parameters on a default, unsignaled video receive stream but + // because we've not configured to receive such a stream, `encodings` is + // empty. return rtp_params; } rtp_params.encodings.emplace_back(); diff --git a/media/engine/webrtc_voice_engine.cc b/media/engine/webrtc_voice_engine.cc index efdb549e70..8511b03a9a 100644 --- a/media/engine/webrtc_voice_engine.cc +++ b/media/engine/webrtc_voice_engine.cc @@ -1479,9 +1479,9 @@ webrtc::RtpParameters WebRtcVoiceMediaChannel::GetDefaultRtpReceiveParameters() RTC_DCHECK_RUN_ON(worker_thread_); webrtc::RtpParameters rtp_params; if (!default_sink_) { - RTC_LOG(LS_WARNING) << "Attempting to get RTP parameters for the default, " - "unsignaled audio receive stream, but not yet " - "configured to receive such a stream."; + // Getting parameters on a default, unsignaled audio receive stream but + // because we've not configured to receive such a stream, `encodings` is + // empty. return rtp_params; } rtp_params.encodings.emplace_back();