From 73eb41fe9eb96bd779cbd9374cb5eaa4c52d02df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A1ri=20Tristan=20Helgason?= Date: Mon, 7 Jan 2019 14:12:04 +0100 Subject: [PATCH] Log reason for dropped frame in RTCCameraVideoCapturer. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: None Change-Id: Ie4a41382c9fbf38c102d3850877545881f6a3d21 Reviewed-on: https://webrtc-review.googlesource.com/c/116063 Commit-Queue: Kári Helgason Reviewed-by: Peter Hanspers Cr-Commit-Position: refs/heads/master@{#26146} --- sdk/objc/components/capturer/RTCCameraVideoCapturer.m | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sdk/objc/components/capturer/RTCCameraVideoCapturer.m b/sdk/objc/components/capturer/RTCCameraVideoCapturer.m index db833b398c..744edf6ae5 100644 --- a/sdk/objc/components/capturer/RTCCameraVideoCapturer.m +++ b/sdk/objc/components/capturer/RTCCameraVideoCapturer.m @@ -287,7 +287,14 @@ const int64_t kNanosecondsPerSecond = 1000000000; - (void)captureOutput:(AVCaptureOutput *)captureOutput didDropSampleBuffer:(CMSampleBufferRef)sampleBuffer fromConnection:(AVCaptureConnection *)connection { - RTCLogError(@"Dropped sample buffer."); +#if TARGET_OS_IPHONE + CFStringRef droppedReason = + CMGetAttachment(sampleBuffer, kCMSampleBufferAttachmentKey_DroppedFrameReason, nil); +#else + // DroppedFrameReason unavailable on macOS. + CFStringRef droppedReason = nil; +#endif + RTCLogError(@"Dropped sample buffer. Reason: %@", (__bridge NSString *)droppedReason); } #pragma mark - AVCaptureSession notifications