From 72302cc5e4ea5aa820e5fe3bc10440dbde2ba362 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Terelius?= Date: Wed, 12 Jun 2024 10:07:50 +0200 Subject: [PATCH] Include-what-you-use rtc_base/numerics/ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:42226242 Change-Id: Ib59078d67af20fa44d79d1a9338b1a3ca6e4c6d2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/354463 Auto-Submit: Björn Terelius Reviewed-by: Harald Alvestrand Commit-Queue: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#42492} --- rtc_base/BUILD.gn | 3 +++ rtc_base/numerics/divide_round_unittest.cc | 2 ++ rtc_base/numerics/event_based_exponential_moving_average.cc | 2 ++ .../event_based_exponential_moving_average_unittest.cc | 2 ++ rtc_base/numerics/event_rate_counter.cc | 4 ++++ rtc_base/numerics/event_rate_counter.h | 4 ++++ rtc_base/numerics/histogram_percentile_counter.cc | 3 +++ rtc_base/numerics/moving_average.cc | 3 +++ rtc_base/numerics/moving_average_unittest.cc | 1 + rtc_base/numerics/moving_percentile_filter_unittest.cc | 1 + rtc_base/numerics/running_statistics.h | 2 +- rtc_base/numerics/safe_compare.h | 1 - rtc_base/numerics/safe_compare_unittest.cc | 2 ++ rtc_base/numerics/safe_minmax.h | 1 + rtc_base/numerics/safe_minmax_unittest.cc | 2 ++ rtc_base/numerics/sample_counter.cc | 2 ++ rtc_base/numerics/sample_counter_unittest.cc | 1 + rtc_base/numerics/sample_stats.cc | 6 ++++++ rtc_base/numerics/sample_stats.h | 1 - rtc_base/numerics/sequence_number_unwrapper.h | 1 + rtc_base/numerics/sequence_number_unwrapper_unittest.cc | 1 + rtc_base/numerics/sequence_number_util.h | 1 - rtc_base/numerics/sequence_number_util_unittest.cc | 1 + 23 files changed, 43 insertions(+), 4 deletions(-) diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn index 85ec8edb9b..5405241ba6 100644 --- a/rtc_base/BUILD.gn +++ b/rtc_base/BUILD.gn @@ -818,6 +818,7 @@ rtc_library("rtc_stats_counters") { "numerics/sample_stats.h", ] deps = [ + ":checks", "../api/numerics", "../api/units:data_rate", "../api/units:time_delta", @@ -2078,11 +2079,13 @@ if (rtc_include_tests) { "numerics/sequence_number_util_unittest.cc", ] deps = [ + ":mod_ops", ":rtc_numerics", ":timeutils", "../test:test_main", "../test:test_support", "//third_party/abseil-cpp/absl/algorithm:container", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/rtc_base/numerics/divide_round_unittest.cc b/rtc_base/numerics/divide_round_unittest.cc index 00548e1cb2..c0934e64af 100644 --- a/rtc_base/numerics/divide_round_unittest.cc +++ b/rtc_base/numerics/divide_round_unittest.cc @@ -10,7 +10,9 @@ #include "rtc_base/numerics/divide_round.h" +#include #include +#include #include "test/gtest.h" diff --git a/rtc_base/numerics/event_based_exponential_moving_average.cc b/rtc_base/numerics/event_based_exponential_moving_average.cc index b426fdeed7..048eb0d1ae 100644 --- a/rtc_base/numerics/event_based_exponential_moving_average.cc +++ b/rtc_base/numerics/event_based_exponential_moving_average.cc @@ -11,6 +11,8 @@ #include "rtc_base/numerics/event_based_exponential_moving_average.h" #include +#include +#include #include "rtc_base/checks.h" diff --git a/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc b/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc index 967be41213..89d9c5f5ae 100644 --- a/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc +++ b/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc @@ -11,6 +11,8 @@ #include "rtc_base/numerics/event_based_exponential_moving_average.h" #include +#include +#include #include "test/gtest.h" diff --git a/rtc_base/numerics/event_rate_counter.cc b/rtc_base/numerics/event_rate_counter.cc index d7b7293918..52c9de64fc 100644 --- a/rtc_base/numerics/event_rate_counter.cc +++ b/rtc_base/numerics/event_rate_counter.cc @@ -10,6 +10,10 @@ #include "rtc_base/numerics/event_rate_counter.h" #include +#include + +#include "api/units/time_delta.h" +#include "api/units/timestamp.h" namespace webrtc { diff --git a/rtc_base/numerics/event_rate_counter.h b/rtc_base/numerics/event_rate_counter.h index 60ec3ba416..ef107ba514 100644 --- a/rtc_base/numerics/event_rate_counter.h +++ b/rtc_base/numerics/event_rate_counter.h @@ -10,6 +10,10 @@ #ifndef RTC_BASE_NUMERICS_EVENT_RATE_COUNTER_H_ #define RTC_BASE_NUMERICS_EVENT_RATE_COUNTER_H_ +#include + +#include "api/units/time_delta.h" +#include "api/units/timestamp.h" #include "rtc_base/numerics/sample_stats.h" namespace webrtc { diff --git a/rtc_base/numerics/histogram_percentile_counter.cc b/rtc_base/numerics/histogram_percentile_counter.cc index 29d2341c85..498bb4bce5 100644 --- a/rtc_base/numerics/histogram_percentile_counter.cc +++ b/rtc_base/numerics/histogram_percentile_counter.cc @@ -12,7 +12,10 @@ #include #include +#include +#include +#include "absl/types/optional.h" #include "rtc_base/checks.h" namespace rtc { diff --git a/rtc_base/numerics/moving_average.cc b/rtc_base/numerics/moving_average.cc index c825839227..126223e2f2 100644 --- a/rtc_base/numerics/moving_average.cc +++ b/rtc_base/numerics/moving_average.cc @@ -11,7 +11,10 @@ #include "rtc_base/numerics/moving_average.h" #include +#include +#include +#include "absl/types/optional.h" #include "rtc_base/checks.h" namespace rtc { diff --git a/rtc_base/numerics/moving_average_unittest.cc b/rtc_base/numerics/moving_average_unittest.cc index 9bc9a1aef8..5993401458 100644 --- a/rtc_base/numerics/moving_average_unittest.cc +++ b/rtc_base/numerics/moving_average_unittest.cc @@ -10,6 +10,7 @@ #include "rtc_base/numerics/moving_average.h" +#include "absl/types/optional.h" #include "test/gtest.h" namespace test { diff --git a/rtc_base/numerics/moving_percentile_filter_unittest.cc b/rtc_base/numerics/moving_percentile_filter_unittest.cc index 30c0ebb23d..f456108973 100644 --- a/rtc_base/numerics/moving_percentile_filter_unittest.cc +++ b/rtc_base/numerics/moving_percentile_filter_unittest.cc @@ -13,6 +13,7 @@ #include #include +#include #include "test/gtest.h" diff --git a/rtc_base/numerics/running_statistics.h b/rtc_base/numerics/running_statistics.h index fe991b043f..134b8957bc 100644 --- a/rtc_base/numerics/running_statistics.h +++ b/rtc_base/numerics/running_statistics.h @@ -13,7 +13,7 @@ #include #include -#include +#include #include "absl/types/optional.h" #include "rtc_base/checks.h" diff --git a/rtc_base/numerics/safe_compare.h b/rtc_base/numerics/safe_compare.h index 85f0a30e83..d3d918d653 100644 --- a/rtc_base/numerics/safe_compare.h +++ b/rtc_base/numerics/safe_compare.h @@ -35,7 +35,6 @@ #include #include -#include #include "rtc_base/type_traits.h" diff --git a/rtc_base/numerics/safe_compare_unittest.cc b/rtc_base/numerics/safe_compare_unittest.cc index 92bde686ba..e7e0e0ba32 100644 --- a/rtc_base/numerics/safe_compare_unittest.cc +++ b/rtc_base/numerics/safe_compare_unittest.cc @@ -10,7 +10,9 @@ #include "rtc_base/numerics/safe_compare.h" +#include #include +#include #include "test/gtest.h" diff --git a/rtc_base/numerics/safe_minmax.h b/rtc_base/numerics/safe_minmax.h index 8356536dbc..cdb6da2909 100644 --- a/rtc_base/numerics/safe_minmax.h +++ b/rtc_base/numerics/safe_minmax.h @@ -76,6 +76,7 @@ #ifndef RTC_BASE_NUMERICS_SAFE_MINMAX_H_ #define RTC_BASE_NUMERICS_SAFE_MINMAX_H_ +#include #include #include diff --git a/rtc_base/numerics/safe_minmax_unittest.cc b/rtc_base/numerics/safe_minmax_unittest.cc index c52b3f93dc..2aa0221149 100644 --- a/rtc_base/numerics/safe_minmax_unittest.cc +++ b/rtc_base/numerics/safe_minmax_unittest.cc @@ -11,7 +11,9 @@ #include "rtc_base/numerics/safe_minmax.h" #include +#include #include +#include #include "test/gtest.h" diff --git a/rtc_base/numerics/sample_counter.cc b/rtc_base/numerics/sample_counter.cc index 78e35fdb5b..5e63b97083 100644 --- a/rtc_base/numerics/sample_counter.cc +++ b/rtc_base/numerics/sample_counter.cc @@ -10,8 +10,10 @@ #include "rtc_base/numerics/sample_counter.h" +#include #include +#include "absl/types/optional.h" #include "rtc_base/checks.h" #include "rtc_base/numerics/safe_conversions.h" diff --git a/rtc_base/numerics/sample_counter_unittest.cc b/rtc_base/numerics/sample_counter_unittest.cc index ffc8b89f6f..6877f5e4e7 100644 --- a/rtc_base/numerics/sample_counter_unittest.cc +++ b/rtc_base/numerics/sample_counter_unittest.cc @@ -12,6 +12,7 @@ #include +#include "absl/types/optional.h" #include "test/gmock.h" #include "test/gtest.h" diff --git a/rtc_base/numerics/sample_stats.cc b/rtc_base/numerics/sample_stats.cc index 6000b2b88f..606b1b6247 100644 --- a/rtc_base/numerics/sample_stats.cc +++ b/rtc_base/numerics/sample_stats.cc @@ -9,6 +9,12 @@ */ #include "rtc_base/numerics/sample_stats.h" +#include + +#include "api/units/data_rate.h" +#include "api/units/time_delta.h" +#include "rtc_base/checks.h" + namespace webrtc { double SampleStats::Max() { diff --git a/rtc_base/numerics/sample_stats.h b/rtc_base/numerics/sample_stats.h index 39af1c6a37..11a884ba32 100644 --- a/rtc_base/numerics/sample_stats.h +++ b/rtc_base/numerics/sample_stats.h @@ -13,7 +13,6 @@ #include "api/numerics/samples_stats_counter.h" #include "api/units/data_rate.h" #include "api/units/time_delta.h" -#include "api/units/timestamp.h" namespace webrtc { template diff --git a/rtc_base/numerics/sequence_number_unwrapper.h b/rtc_base/numerics/sequence_number_unwrapper.h index d741b5c910..fb21283567 100644 --- a/rtc_base/numerics/sequence_number_unwrapper.h +++ b/rtc_base/numerics/sequence_number_unwrapper.h @@ -14,6 +14,7 @@ #include #include +#include #include "absl/types/optional.h" #include "rtc_base/numerics/sequence_number_util.h" diff --git a/rtc_base/numerics/sequence_number_unwrapper_unittest.cc b/rtc_base/numerics/sequence_number_unwrapper_unittest.cc index fcd903bab4..10ffecb311 100644 --- a/rtc_base/numerics/sequence_number_unwrapper_unittest.cc +++ b/rtc_base/numerics/sequence_number_unwrapper_unittest.cc @@ -11,6 +11,7 @@ #include "rtc_base/numerics/sequence_number_unwrapper.h" #include +#include #include "test/gtest.h" diff --git a/rtc_base/numerics/sequence_number_util.h b/rtc_base/numerics/sequence_number_util.h index 702b82fa2b..0eafaa887f 100644 --- a/rtc_base/numerics/sequence_number_util.h +++ b/rtc_base/numerics/sequence_number_util.h @@ -11,7 +11,6 @@ #ifndef RTC_BASE_NUMERICS_SEQUENCE_NUMBER_UTIL_H_ #define RTC_BASE_NUMERICS_SEQUENCE_NUMBER_UTIL_H_ -#include #include #include diff --git a/rtc_base/numerics/sequence_number_util_unittest.cc b/rtc_base/numerics/sequence_number_util_unittest.cc index d44127bfa5..f23c1065b0 100644 --- a/rtc_base/numerics/sequence_number_util_unittest.cc +++ b/rtc_base/numerics/sequence_number_util_unittest.cc @@ -14,6 +14,7 @@ #include #include +#include "rtc_base/numerics/mod_ops.h" #include "test/gtest.h" namespace webrtc {