From 71cfe690b709d47432e0bcd12add737e2ed94fe6 Mon Sep 17 00:00:00 2001 From: deadbeef Date: Tue, 1 Sep 2015 19:01:33 -0700 Subject: [PATCH] For TestResolverShutdown, use address that can't be resolved. This test only currently works because stun.l.google.com has an IPv4 address and the TURN port is created with an IPv6 address. But the test would start failing if/when it starts providing an IPv6 address. Which may already be happening, as indicated by a recent test failure. Review URL: https://codereview.webrtc.org/1290233003 Cr-Commit-Position: refs/heads/master@{#9841} --- webrtc/p2p/base/turnport_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webrtc/p2p/base/turnport_unittest.cc b/webrtc/p2p/base/turnport_unittest.cc index 2041d4f2b6..a90ea032b7 100644 --- a/webrtc/p2p/base/turnport_unittest.cc +++ b/webrtc/p2p/base/turnport_unittest.cc @@ -803,7 +803,7 @@ TEST_F(TurnPortTest, TestResolverShutdown) { // Need to supply unresolved address to kick off resolver. CreateTurnPort(kLocalIPv6Addr, kTurnUsername, kTurnPassword, cricket::ProtocolAddress(rtc::SocketAddress( - "stun.l.google.com", 3478), cricket::PROTO_UDP)); + "www.google.invalid", 3478), cricket::PROTO_UDP)); turn_port_->PrepareAddress(); ASSERT_TRUE_WAIT(turn_error_, kTimeout); EXPECT_TRUE(turn_port_->Candidates().empty());