admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add corruption detection header default as stopped.

Browse Source 
Bug: webrtc:358039777
Change-Id: I957638c4a84f26391b09af677cc7aaf2bf2024ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368000
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43385}
This commit is contained in:
Emil Vardar 2024-11-08 15:27:34 +00:00 committed by WebRTC LUCI CQ
parent 849549d403
commit 71ba9cbb80
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
media/engine/webrtc_video_engine.cc
View File

@ -846,6 +846,9 @@ WebRtcVideoEngine::GetRtpHeaderExtensions() const {
webrtc::RtpExtension::kRidUri, webrtc::RtpExtension::kRepairedRidUri}) { webrtc::RtpExtension::kRidUri, webrtc::RtpExtension::kRepairedRidUri}) {
result.emplace_back(uri, id++, webrtc::RtpTransceiverDirection::kSendRecv); result.emplace_back(uri, id++, webrtc::RtpTransceiverDirection::kSendRecv);
} }
result.emplace_back(webrtc::RtpExtension::kCorruptionDetectionUri, id++,
/*preferred_encrypt=*/true,
webrtc::RtpTransceiverDirection::kStopped);
for (const auto& uri : {webrtc::RtpExtension::kAbsoluteCaptureTimeUri}) { for (const auto& uri : {webrtc::RtpExtension::kAbsoluteCaptureTimeUri}) {
result.emplace_back(uri, id, webrtc::RtpTransceiverDirection::kStopped); result.emplace_back(uri, id, webrtc::RtpTransceiverDirection::kStopped);
} }

7
media/engine/webrtc_video_engine_unittest.cc
View File

@ -507,6 +507,10 @@ TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false); ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
} }
TEST_F(WebRtcVideoEngineTest, SupportCorruptionDetectionHeaderExtension) {
ExpectRtpCapabilitySupport(RtpExtension::kCorruptionDetectionUri, false);
}
class WebRtcVideoEngineTestWithGenericDescriptor class WebRtcVideoEngineTestWithGenericDescriptor
: public WebRtcVideoEngineTest { : public WebRtcVideoEngineTest {
public: public:
@ -3176,6 +3180,9 @@ TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
TEST_F(WebRtcVideoChannelTest, SendCorruptionDetectionHeaderExtensions) { TEST_F(WebRtcVideoChannelTest, SendCorruptionDetectionHeaderExtensions) {
TestSetSendRtpHeaderExtensions(RtpExtension::kCorruptionDetectionUri); TestSetSendRtpHeaderExtensions(RtpExtension::kCorruptionDetectionUri);
} }
TEST_F(WebRtcVideoChannelTest, RecvCorruptionDetectionHeaderExtensions) {
TestSetRecvRtpHeaderExtensions(RtpExtension::kCorruptionDetectionUri);
}
TEST_F(WebRtcVideoChannelTest, DisableFrameInstrumentationByDefault) { TEST_F(WebRtcVideoChannelTest, DisableFrameInstrumentationByDefault) {
EXPECT_TRUE(send_channel_->SetSenderParameters(send_parameters_)); EXPECT_TRUE(send_channel_->SetSenderParameters(send_parameters_));