admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disallow pairing ICE-TCP with a local ip address

Browse Source 
BUG=chromium:1038754

Change-Id: Iab7186efd39a94bffde19e0c39a49f6bc61802ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167060
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30457}
This commit is contained in:
Philipp Hancke 2020-02-04 17:44:46 +01:00 committed by Commit Bot
parent 7c3a1fc082
commit 712ebbb5b7
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pc/jsep_transport_controller.cc
View File

@ -59,6 +59,13 @@ webrtc::RTCError VerifyCandidate(const cricket::Candidate& cand) {
}
}
// Disallow ICE-TCP with a private IP address.
if (cand.protocol() == cricket::TCP_PROTOCOL_NAME &&
cand.address().IsPrivateIP()) {
return webrtc::RTCError(webrtc::RTCErrorType::INVALID_PARAMETER,
"candidate is TCP and has a private IP address");
}
return webrtc::RTCError::OK();
}