From 70d9e4e02b7e9249505efdd3dd57e42bde5cbf84 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Wed, 21 Dec 2022 10:51:54 +0000 Subject: [PATCH] Don't log PW mismatch messages in production The STUN message about mismatched passwords is not interesting. Only emit it in VERBOSE mode when DCHECK is on. Bug: webrtc:14578 Change-Id: Ie83080d88be6da24e7f2f79d7eb279087f84c2a0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288740 Reviewed-by: Jonas Oreland Commit-Queue: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#38938} --- p2p/base/connection.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/p2p/base/connection.cc b/p2p/base/connection.cc index f49c02234f..a79a449cff 100644 --- a/p2p/base/connection.cc +++ b/p2p/base/connection.cc @@ -483,9 +483,10 @@ void Connection::OnReadPacket(const char* data, case StunMessage::IntegrityStatus::kIntegrityOk: if (remote_candidate().password() != msg->password()) { // TODO(bugs.webrtc.org/14578): Do a better thing - RTC_LOG(LS_INFO) << "STUN code error - Different passwords, old = " - << absl::CHexEscape(msg->password()) << ", new " - << absl::CHexEscape(remote_candidate().password()); + RTC_DLOG(LS_VERBOSE) + << "STUN code error - Different passwords, old = " + << absl::CHexEscape(msg->password()) << ", new " + << absl::CHexEscape(remote_candidate().password()); } break; default: