From 70aa374d3eccdd6369f2ed3f3fd03f47ed59974e Mon Sep 17 00:00:00 2001 From: Jonathan Yu Date: Tue, 10 Jul 2018 12:45:34 -0700 Subject: [PATCH] Remove not-updating-stats log message. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GetStats() is currently the only way to get smoothed audio levels. It's expected to be called quite frequently. We use 100ms intervals, so a call to GetStats() for any reason other than audio levels has a 50% chance of triggering this log line. This makes it too noisy for LS_INFO. The log line was added recently (https://webrtc-review.googlesource.com/c/src/+/82260) and doesn't seem very useful for diagnostic purposes, so remove it entirely. Bug: webrtc:9519 Change-Id: I15700085c60b9929a4df2e2327012a4f16b505b6 Reviewed-on: https://webrtc-review.googlesource.com/88003 Commit-Queue: Jonathan Yu Reviewed-by: Noah Richards Reviewed-by: Henrik Boström Reviewed-by: Honghai Zhang Cr-Commit-Position: refs/heads/master@{#23939} --- pc/statscollector.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/pc/statscollector.cc b/pc/statscollector.cc index 0018b10c8b..2a5936830c 100644 --- a/pc/statscollector.cc +++ b/pc/statscollector.cc @@ -555,9 +555,6 @@ void StatsCollector::UpdateStats( const double kMinGatherStatsPeriod = 50; if (stats_gathering_started_ != 0 && stats_gathering_started_ + kMinGatherStatsPeriod > time_now) { - RTC_LOG(LS_INFO) - << "Not updating stats again, since they were updated within " - << kMinGatherStatsPeriod << "ms."; return; } stats_gathering_started_ = time_now;