From 7040090ae68a706ab6d293f3ba61aaec5f2b6f9f Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Tue, 21 Aug 2018 15:44:28 +0200 Subject: [PATCH] Introduce rtc_exclude_field_trial_default GN argument. This GN argument will be used to exclude the default implementation of field trial in order to allow clients to provide a custom implementation. This will allow to land [1] without breaking Chromium. [1] - https://webrtc-review.googlesource.com/c/src/+/94766 Bug: webrtc:9631 Change-Id: If7872d0c019fbb526a0b121a58caba51268d637d Reviewed-on: https://webrtc-review.googlesource.com/95105 Commit-Queue: Mirko Bonadei Reviewed-by: Karl Wiberg Cr-Commit-Position: refs/heads/master@{#24361} --- webrtc.gni | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/webrtc.gni b/webrtc.gni index eeb25c0edb..4b1f028e6f 100644 --- a/webrtc.gni +++ b/webrtc.gni @@ -31,6 +31,14 @@ if (is_ios) { } declare_args() { + # WARNING: This argument doesn't have any effect on the WebRTC build until + # https://webrtc-review.googlesource.com/c/src/+/94766 will land. + # Setting this to false will define WEBRTC_EXCLUDE_FIELD_TRIAL_DEFAULT which + # will tell the pre-processor to remove the default definition of symbols + # needed to use field_trial. In that case a new implementation needs to be + # provided. + rtc_exclude_field_trial_default = true + # Setting this to false will require the API user to pass in their own # SSLCertificateVerifier to verify the certificates presented from a # TLS-TURN server. In return disabling this saves around 100kb in the binary.