From 6ffe825ec158209c78da3668811653429d1f1f1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Bostr=C3=B6m?= Date: Fri, 10 Mar 2023 12:22:00 +0100 Subject: [PATCH] Disable flaky PictureIdTests. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://ci.chromium.org/p/webrtc/builders/try/fuchsia_rel Bug: webrtc:14985 Change-Id: I7213b8a257626028c34511a0539c0445494ae3fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296920 Commit-Queue: Henrik Boström Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/main@{#39525} --- video/picture_id_tests.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/video/picture_id_tests.cc b/video/picture_id_tests.cc index 06491b924a..71b1c34424 100644 --- a/video/picture_id_tests.cc +++ b/video/picture_id_tests.cc @@ -367,7 +367,8 @@ TEST_P(PictureIdTest, ContinuousAfterReconfigureVp8) { TestPictureIdContinuousAfterReconfigure({1, 3, 3, 1, 1}); } -TEST_P(PictureIdTest, IncreasingAfterRecreateStreamVp8) { +// TODO(bugs.webrtc.org/14985): Investigate and reenable. +TEST_P(PictureIdTest, DISABLED_IncreasingAfterRecreateStreamVp8) { test::FunctionVideoEncoderFactory encoder_factory( []() { return VP8Encoder::Create(); }); SetupEncoder(&encoder_factory, "VP8"); @@ -394,7 +395,9 @@ TEST_P(PictureIdTest, ContinuousAfterReconfigureSimulcastEncoderAdapter) { TestPictureIdContinuousAfterReconfigure({1, 3, 3, 1, 1}); } -TEST_P(PictureIdTest, IncreasingAfterRecreateStreamSimulcastEncoderAdapter) { +// TODO(bugs.webrtc.org/14985): Investigate and reenable. +TEST_P(PictureIdTest, + DISABLED_IncreasingAfterRecreateStreamSimulcastEncoderAdapter) { InternalEncoderFactory internal_encoder_factory; test::FunctionVideoEncoderFactory encoder_factory( [&internal_encoder_factory]() { @@ -418,7 +421,8 @@ TEST_P(PictureIdTest, ContinuousAfterStreamCountChangeSimulcastEncoderAdapter) { TestPictureIdContinuousAfterReconfigure({3, 1, 3}); } -TEST_P(PictureIdTest, IncreasingAfterRecreateStreamVp9) { +// TODO(bugs.webrtc.org/14985): Investigate and reenable. +TEST_P(PictureIdTest, DISABLED_IncreasingAfterRecreateStreamVp9) { test::FunctionVideoEncoderFactory encoder_factory( []() { return VP9Encoder::Create(); }); SetupEncoder(&encoder_factory, "VP9");