admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sdp: use const references to fields

Browse Source 
BUG=webrtc:11718

Change-Id: I60bdfcdadef665f6044525046ec25717102365d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178363
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31580}
This commit is contained in:
Philipp Hancke 2020-06-29 12:32:08 +02:00 committed by Commit Bot
parent e6ac8ff162
commit 6fb7004f33
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pc/webrtc_sdp.cc
View File

@ -2625,7 +2625,7 @@ bool ParseMediaDescription(
if (!rtc::FromString<int>(fields[1], &port) || !IsValidPort(port)) {
return ParseFailed(line, "The port number is invalid", error);
}
std::string protocol = fields[2];
const std::string& protocol = fields[2];
// <fmt>
std::vector<int> payload_types;
@ -2656,18 +2656,18 @@ bool ParseMediaDescription(
std::string content_name;
bool bundle_only = false;
int section_msid_signaling = 0;
std::string mediaType = fields[0];
if (mediaType == kMediaTypeVideo) {
const std::string& media_type = fields[0];
if (media_type == kMediaTypeVideo) {
content = ParseContentDescription<VideoContentDescription>(
message, cricket::MEDIA_TYPE_VIDEO, mline_index, protocol,
payload_types, pos, &content_name, &bundle_only,
&section_msid_signaling, &transport, candidates, error);
} else if (mediaType == kMediaTypeAudio) {
} else if (media_type == kMediaTypeAudio) {
content = ParseContentDescription<AudioContentDescription>(
message, cricket::MEDIA_TYPE_AUDIO, mline_index, protocol,
payload_types, pos, &content_name, &bundle_only,
&section_msid_signaling, &transport, candidates, error);
} else if (mediaType == kMediaTypeData) {
} else if (media_type == kMediaTypeData) {
if (cricket::IsDtlsSctp(protocol)) {
// The draft-03 format is:
// m=application <port> DTLS/SCTP <sctp-port>...