admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract corruption detection message to its own target

Browse Source 
Bug: webrtc:358039777
Change-Id: I6bc064aaba4c5b7f9b55215414e70e55eb0e0f64
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361864
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42977}
This commit is contained in:
Fanny Linderborg 2024-09-06 14:06:17 +02:00 committed by WebRTC LUCI CQ
parent 65b46da1f8
commit 6f64ae1ff5
3 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
common_video/BUILD.gn
View File

@ -8,6 +8,14 @@
import("../webrtc.gni") import("../webrtc.gni")
rtc_library("corruption_detection_message") {
sources = [ "corruption_detection_message.h" ]
deps = [
"../api:array_view",
"//third_party/abseil-cpp/absl/container:inlined_vector",
]
}
rtc_library("frame_instrumentation_data") { rtc_library("frame_instrumentation_data") {
sources = [ "frame_instrumentation_data.h" ] sources = [ "frame_instrumentation_data.h" ]
} }
@ -17,7 +25,6 @@ rtc_library("common_video") {
sources = [ sources = [
"bitrate_adjuster.cc", "bitrate_adjuster.cc",
"corruption_detection_message.h",
"frame_rate_estimator.cc", "frame_rate_estimator.cc",
"frame_rate_estimator.h", "frame_rate_estimator.h",
"framerate_controller.cc", "framerate_controller.cc",
@ -60,7 +67,6 @@ rtc_library("common_video") {
} }
deps = [ deps = [
":frame_instrumentation_data",
"../api:array_view", "../api:array_view",
"../api:make_ref_counted", "../api:make_ref_counted",
"../api:scoped_refptr", "../api:scoped_refptr",
@ -91,7 +97,6 @@ rtc_library("common_video") {
"../rtc_base/synchronization:mutex", "../rtc_base/synchronization:mutex",
"../rtc_base/system:rtc_export", "../rtc_base/system:rtc_export",
"../system_wrappers:metrics", "../system_wrappers:metrics",
"//third_party/abseil-cpp/absl/container:inlined_vector",
"//third_party/abseil-cpp/absl/numeric:bits", "//third_party/abseil-cpp/absl/numeric:bits",
"//third_party/libyuv", "//third_party/libyuv",
] ]
@ -120,12 +125,20 @@ if (rtc_include_tests && !build_with_chromium) {
} }
} }
rtc_library("corruption_detection_message_unittest") {
testonly = true
sources = [ "corruption_detection_message_unittest.cc" ]
deps = [
":corruption_detection_message",
"../test:test_support",
]
}
rtc_test("common_video_unittests") { rtc_test("common_video_unittests") {
testonly = true testonly = true
sources = [ sources = [
"bitrate_adjuster_unittest.cc", "bitrate_adjuster_unittest.cc",
"corruption_detection_message_unittest.cc",
"frame_rate_estimator_unittest.cc", "frame_rate_estimator_unittest.cc",
"framerate_controller_unittest.cc", "framerate_controller_unittest.cc",
"h264/h264_bitstream_parser_unittest.cc", "h264/h264_bitstream_parser_unittest.cc",
@ -148,6 +161,7 @@ if (rtc_include_tests && !build_with_chromium) {
deps = [ deps = [
":common_video", ":common_video",
":corruption_detection_message_unittest",
"../api:scoped_refptr", "../api:scoped_refptr",
"../api/units:time_delta", "../api/units:time_delta",
"../api/video:video_frame", "../api/video:video_frame",

5
modules/rtp_rtcp/BUILD.gn
View File

@ -126,7 +126,7 @@ rtc_library("rtp_rtcp_format") {
"../../api/units:timestamp", "../../api/units:timestamp",
"../../api/video:video_layers_allocation", "../../api/video:video_layers_allocation",
"../../api/video:video_rtp_headers", "../../api/video:video_rtp_headers",
"../../common_video:common_video", "../../common_video:corruption_detection_message",
"../../rtc_base:bit_buffer", "../../rtc_base:bit_buffer",
"../../rtc_base:bitstream_reader", "../../rtc_base:bitstream_reader",
"../../rtc_base:buffer", "../../rtc_base:buffer",
@ -139,7 +139,6 @@ rtc_library("rtp_rtcp_format") {
"../../rtc_base:safe_conversions", "../../rtc_base:safe_conversions",
"../../rtc_base:stringutils", "../../rtc_base:stringutils",
"../../rtc_base/network:ecn_marking", "../../rtc_base/network:ecn_marking",
"../../rtc_base/synchronization:mutex",
"../../system_wrappers", "../../system_wrappers",
"../video_coding:codec_globals_headers", "../video_coding:codec_globals_headers",
"//third_party/abseil-cpp/absl/algorithm:container", "//third_party/abseil-cpp/absl/algorithm:container",
@ -763,7 +762,7 @@ if (rtc_include_tests) {
sources = [ "source/corruption_detection_extension_unittest.cc" ] sources = [ "source/corruption_detection_extension_unittest.cc" ]
deps = [ deps = [
":rtp_rtcp_format", ":rtp_rtcp_format",
"../../common_video:common_video", "../../common_video:corruption_detection_message",
"../../test:test_support", "../../test:test_support",
] ]
} }

2
test/fuzzers/BUILD.gn
View File

@ -236,7 +236,7 @@ webrtc_fuzzer_test("rtcp_receiver_fuzzer") {
webrtc_fuzzer_test("rtp_packet_fuzzer") { webrtc_fuzzer_test("rtp_packet_fuzzer") {
sources = [ "rtp_packet_fuzzer.cc" ] sources = [ "rtp_packet_fuzzer.cc" ]
deps = [ deps = [
"../../common_video:common_video", "../../common_video:corruption_detection_message",
"../../modules/rtp_rtcp:rtp_rtcp_format", "../../modules/rtp_rtcp:rtp_rtcp_format",
] ]
seed_corpus = "corpora/rtp-corpus" seed_corpus = "corpora/rtp-corpus"