From 6f2bf6deb3d6fb5744ef722c878ed701792b72d3 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Tue, 27 Sep 2022 11:49:20 +0000 Subject: [PATCH] Add missing dependency. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As mentioned in [1] declarations and definitions of the same symbol should be part of the same library. For some old code, this is not the case, and this can lead to hard to debug linker errors like the ones from –warn-backrefs. This CL adds the dependency to the defintion of call::Create() to a target that uses it (and depends on the declaration from call:call_interfaces). In the future, call:call_interfaces should be removed entirely. [1] - https://webrtc.googlesource.com/src/+/refs/heads/main/g3doc/style-guide/h-cc-pairs.md Bug: None Change-Id: I5f8fb6fa79815f1ff6b5199b9c682d7c9e73b616 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276941 Reviewed-by: Jonas Oreland Commit-Queue: Mirko Bonadei Auto-Submit: Mirko Bonadei Commit-Queue: Jonas Oreland Cr-Commit-Position: refs/heads/main@{#38221} --- test/BUILD.gn | 1 + 1 file changed, 1 insertion(+) diff --git a/test/BUILD.gn b/test/BUILD.gn index 6acea6ec84..df84de8dc9 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -991,6 +991,7 @@ rtc_library("test_common") { "../api/video:video_bitrate_allocator_factory", "../api/video:video_frame", "../api/video_codecs:video_codecs_api", + "../call", "../call:call_interfaces", "../call:fake_network", "../call:simulated_network",