From 6ef0a3816e9c959a84f7de3e0fe983dbe3b114ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Wed, 25 May 2022 11:00:36 +0200 Subject: [PATCH] Delete old StringToProto signature Bug: webrtc:13579 Change-Id: I9bc01ce6e41a906d962522d0b395702db7a578f7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263583 Reviewed-by: Jonas Oreland Commit-Queue: Niels Moller Cr-Commit-Position: refs/heads/main@{#37065} --- p2p/base/port.cc | 9 --------- p2p/base/port.h | 3 --- 2 files changed, 12 deletions(-) diff --git a/p2p/base/port.cc b/p2p/base/port.cc index 0d76614857..d3d2661e2c 100644 --- a/p2p/base/port.cc +++ b/p2p/base/port.cc @@ -89,15 +89,6 @@ absl::optional StringToProto(absl::string_view proto_name) { return absl::nullopt; } -bool StringToProto(const char* value, ProtocolType* proto) { - if (absl::optional type = StringToProto(value); - type.has_value()) { - *proto = *type; - return true; - } - return false; -} - // RFC 6544, TCP candidate encoding rules. const int DISCARD_PORT = 9; const char TCPTYPE_ACTIVE_STR[] = "active"; diff --git a/p2p/base/port.h b/p2p/base/port.h index dd7b3e3c02..6a5bdfcc9b 100644 --- a/p2p/base/port.h +++ b/p2p/base/port.h @@ -128,9 +128,6 @@ typedef std::vector CandidateStatsList; const char* ProtoToString(ProtocolType proto); absl::optional StringToProto(absl::string_view proto_name); -// TODO(bugs.webrtc.org/13579): Delete once downstream usage is updated. -[[deprecated]] bool StringToProto(const char* value, ProtocolType* proto); - struct ProtocolAddress { rtc::SocketAddress address; ProtocolType proto;