admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix TestExtendedReportsCanSignalZeroTargetBitrate flakiness on Mac.

Browse Source 
The test is flaky on Mac on it seems related to a timeout.
https://luci-analysis.appspot.com/p/webrtc/clusters/testname-v4/82d0b764552f0811b37cc651c0962399?tab=recent-failures

../../video/end_to_end_tests/extended_reports_tests.cc:196: Failure
Value of: Wait()
  Actual: false
Expected: true
Timed out while waiting for RTCP SR/RR packets to be sent.

Change-Id: I9b19d3952a761415ab65d15f188ae3336e43e97e
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357820
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42672}
This commit is contained in:
Jeremy Leconte 2024-07-24 17:26:35 +02:00 committed by WebRTC LUCI CQ
parent 161956b89d
commit 6ed136c6ae
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
video/end_to_end_tests/extended_reports_tests.cc
View File

@ -21,6 +21,7 @@
#include "api/task_queue/task_queue_base.h"
#include "api/test/simulated_network.h"
#include "api/units/data_rate.h"
#include "api/units/time_delta.h"
#include "api/video_codecs/sdp_video_format.h"
#include "call/call.h"
#include "call/fake_network_pipe.h"
@ -64,8 +65,9 @@ class RtcpXrObserver : public test::EndToEndTest {
RtcpXrObserver(bool enable_rrtr,
bool expect_target_bitrate,
bool enable_zero_target_bitrate,
VideoEncoderConfig::ContentType content_type)
: EndToEndTest(test::VideoTestConstants::kDefaultTimeout),
VideoEncoderConfig::ContentType content_type,
TimeDelta timeout = test::VideoTestConstants::kDefaultTimeout)
: EndToEndTest(timeout),
enable_rrtr_(enable_rrtr),
expect_target_bitrate_(expect_target_bitrate),
enable_zero_target_bitrate_(enable_zero_target_bitrate),
@ -260,7 +262,8 @@ TEST_F(ExtendedReportsEndToEndTest,
TestExtendedReportsCanSignalZeroTargetBitrate) {
RtcpXrObserver test(/*enable_rrtr=*/false, /*expect_target_bitrate=*/true,
/*enable_zero_target_bitrate=*/true,
VideoEncoderConfig::ContentType::kScreen);
VideoEncoderConfig::ContentType::kScreen,
test::VideoTestConstants::kLongTimeout);
RunBaseTest(&test);
}
} // namespace webrtc