From 6eb75d9e67f02c256436eb96f3c77026486561a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrik=20H=C3=B6glund?= Date: Wed, 16 Sep 2015 08:41:31 +0200 Subject: [PATCH] Bailing out if pc factory fails to get created. This prevents us from continuing if we fail initialization. The failure will happen closer to its source, rather than when we try to create the first peer connection. BUG=None R=glaznev@webrtc.org Review URL: https://codereview.webrtc.org/1339923004 . Cr-Commit-Position: refs/heads/master@{#9948} --- talk/app/webrtc/java/jni/peerconnection_jni.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/talk/app/webrtc/java/jni/peerconnection_jni.cc b/talk/app/webrtc/java/jni/peerconnection_jni.cc index 35406f5560..bba1e82472 100644 --- a/talk/app/webrtc/java/jni/peerconnection_jni.cc +++ b/talk/app/webrtc/java/jni/peerconnection_jni.cc @@ -1103,6 +1103,8 @@ JOW(jlong, PeerConnectionFactory_nativeCreatePeerConnectionFactory)( NULL, encoder_factory, decoder_factory)); + CHECK(factory) << "Failed to create the peer connection factory; " + << "WebRTC/libjingle init likely failed on this device"; OwnedFactoryAndThreads* owned_factory = new OwnedFactoryAndThreads( worker_thread, signaling_thread, encoder_factory, decoder_factory,