admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup WebRTC-PayloadTypes-Lower-Dynamic-Range trial

Browse Source 
as the killswitch is no longer required.

BUG=webrtc:12194

Change-Id: Icb825012c50a93ec4dae49be5732d9e4c0adb89d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306182
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40149}
This commit is contained in:
Philipp Hancke 2023-05-22 18:27:45 +02:00 committed by WebRTC LUCI CQ
parent 56d126074e
commit 6e23fa52bf
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
media/base/codec.cc
View File

@ -135,18 +135,11 @@ bool Codec::Matches(const Codec& codec,
const webrtc::FieldTrialsView* field_trials) const {
// Match the codec id/name based on the typical static/dynamic name rules.
// Matching is case-insensitive.
// Legacy behaviour with killswitch.
if (field_trials &&
field_trials->IsDisabled("WebRTC-PayloadTypes-Lower-Dynamic-Range")) {
const int kMaxStaticPayloadId = 95;
return (id <= kMaxStaticPayloadId || codec.id <= kMaxStaticPayloadId)
? (id == codec.id)
: (absl::EqualsIgnoreCase(name, codec.name));
}
// We support the ranges [96, 127] and more recently [35, 65].
// https://www.iana.org/assignments/rtp-parameters/rtp-parameters.xhtml#rtp-parameters-1
// Within those ranges we match by codec name, outside by codec id.
// Since no codecs are assigned an id in the range [66, 95] by us, these will
// never match.
const int kLowerDynamicRangeMin = 35;
const int kLowerDynamicRangeMax = 65;
const int kUpperDynamicRangeMin = 96;