From 6df49d8983eb915cb48b49e7e65aae56567b8c8d Mon Sep 17 00:00:00 2001 From: Amit Hilbuch Date: Mon, 15 Apr 2019 15:47:21 -0700 Subject: [PATCH] Fixing issue with creating StreamParams when track id is not signaled. Current logic requires a stream id and track ids when creating a stream that does not have SSRCs signaled. This change removes the requirement for stream ids. The requirement for track id is softer, as one should be generated when it is not present. Bug: webrtc:10551 Change-Id: Ibc0cc181c6b18efa8394b6c0e4820e3a13da70c4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133080 Reviewed-by: Steve Anton Commit-Queue: Amit Hilbuch Cr-Commit-Position: refs/heads/master@{#27633} --- pc/webrtc_sdp.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pc/webrtc_sdp.cc b/pc/webrtc_sdp.cc index b524a75654..984a1e14a1 100644 --- a/pc/webrtc_sdp.cc +++ b/pc/webrtc_sdp.cc @@ -666,8 +666,9 @@ void CreateTrackWithNoSsrcs(const std::vector& msid_stream_ids, const std::vector& rids, StreamParamsVec* tracks) { StreamParams track; - if (msid_track_id.empty() || msid_stream_ids.empty()) { + if (msid_track_id.empty() && rids.empty()) { // We only create an unsignaled track if a=msid lines were signaled. + RTC_LOG(LS_INFO) << "MSID not signaled, skipping creation of StreamParams"; return; } track.set_stream_ids(msid_stream_ids);