admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Refactor webrtc/modules/video_processing for GN check"

Browse Source 
This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2597643002
Cr-Commit-Position: refs/heads/master@{#15805}
This commit is contained in:
mbonadei 2016-12-27 06:32:08 -08:00 committed by Commit bot
parent d5b6d7a7b9
commit 6d3c57300b
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gn
View File

@ -35,6 +35,7 @@ check_targets = [
"//webrtc/modules/utility/*", "//webrtc/modules/utility/*",
"//webrtc/modules/video_capture/*", "//webrtc/modules/video_capture/*",
"//webrtc/modules/video_coding/*", "//webrtc/modules/video_coding/*",
"//webrtc/modules/video_processing/*",
"//webrtc/stats:rtc_stats", "//webrtc/stats:rtc_stats",
"//webrtc/voice_engine", "//webrtc/voice_engine",
"//webrtc/voice_engine:level_indicator", "//webrtc/voice_engine:level_indicator",

15
webrtc/modules/video_processing/BUILD.gn
View File

@ -26,6 +26,7 @@ rtc_static_library("video_processing") {
] ]
deps = [ deps = [
"../../base:rtc_base_approved",
"../../common_audio", "../../common_audio",
"../../common_video", "../../common_video",
"../../modules/utility", "../../modules/utility",
@ -46,11 +47,20 @@ rtc_static_library("video_processing") {
if (build_video_processing_sse2) { if (build_video_processing_sse2) {
rtc_static_library("video_processing_sse2") { rtc_static_library("video_processing_sse2") {
# TODO(mbonadei): Remove (bugs.webrtc.org/6828)
# Errors on cyclic dependency with :video_processing if enabled.
check_includes = false
sources = [ sources = [
"util/denoiser_filter_sse2.cc", "util/denoiser_filter_sse2.cc",
"util/denoiser_filter_sse2.h", "util/denoiser_filter_sse2.h",
] ]
deps = [
"../../base:rtc_base_approved",
"../../system_wrappers",
]
if (!build_with_chromium && is_clang) { if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@ -64,10 +74,15 @@ if (build_video_processing_sse2) {
if (rtc_build_with_neon) { if (rtc_build_with_neon) {
rtc_static_library("video_processing_neon") { rtc_static_library("video_processing_neon") {
# TODO(mbonadei): Remove (bugs.webrtc.org/6828)
# Errors on cyclic dependency with :video_processing if enabled.
check_includes = false
sources = [ sources = [
"util/denoiser_filter_neon.cc", "util/denoiser_filter_neon.cc",
"util/denoiser_filter_neon.h", "util/denoiser_filter_neon.h",
] ]
if (current_cpu != "arm64") { if (current_cpu != "arm64") {
suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ] suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
cflags = [ "-mfpu=neon" ] cflags = [ "-mfpu=neon" ]