From 6ca908f48c88fda174516ec8edc5041f61a432b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrik=20H=C3=B6glund?= Date: Thu, 16 Jan 2020 08:50:13 +0100 Subject: [PATCH] Shorten the fir filter adapt test quite a bit. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test is likely timing out on iOS simulator (see bug). Maybe I'm going a bit overboard here :) if you want to keep all the cases I removed, you can run some cases in one test method and the others in another test method. Are the cases I removed particularly important? Bug: webrtc:11284 Change-Id: I8f2e8830f931594c3471d1c20a2654e258b9fcf0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166169 Reviewed-by: Per Åhgren Commit-Queue: Patrik Höglund Cr-Commit-Position: refs/heads/master@{#30277} --- modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc b/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc index e99ff2adb7..9c48a43af8 100644 --- a/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc +++ b/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc @@ -330,8 +330,8 @@ TEST(AdaptiveFirFilter, FilterAndAdapt) { constexpr size_t kNumBands = NumBandsForRate(kSampleRateHz); constexpr size_t kNumBlocksToProcessPerRenderChannel = 1000; - for (size_t num_capture_channels : {1, 2, 4}) { - for (size_t num_render_channels : {1, 2, 3, 6, 8}) { + for (size_t num_capture_channels : {1, 4}) { + for (size_t num_render_channels : {1, 8}) { ApmDataDumper data_dumper(42); EchoCanceller3Config config;