From 6bfc82aaf18e42fcc7328b81ffb3ec3cf360d732 Mon Sep 17 00:00:00 2001 From: pkasting Date: Tue, 23 Jun 2015 14:38:36 -0700 Subject: [PATCH] Test whether removing a cast still hurts performance. BUG=499241 TEST=none TBR=andrew Review URL: https://codereview.webrtc.org/1206653002 Cr-Commit-Position: refs/heads/master@{#9491} --- webrtc/common_audio/signal_processing/cross_correlation.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/webrtc/common_audio/signal_processing/cross_correlation.c b/webrtc/common_audio/signal_processing/cross_correlation.c index 6c8f22c415..c14ce4c322 100644 --- a/webrtc/common_audio/signal_processing/cross_correlation.c +++ b/webrtc/common_audio/signal_processing/cross_correlation.c @@ -23,10 +23,8 @@ void WebRtcSpl_CrossCorrelationC(int32_t* cross_correlation, for (i = 0; i < dim_cross_correlation; i++) { int32_t corr = 0; /* Unrolling doesn't seem to improve performance. */ - for (j = 0; j < dim_seq; j++) { - // It's not clear why casting |right_shifts| here helps performance. - corr += (seq1[j] * seq2[j]) >> (int16_t)right_shifts; - } + for (j = 0; j < dim_seq; j++) + corr += (seq1[j] * seq2[j]) >> right_shifts; seq2 += step_seq2; *cross_correlation++ = corr; }