admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adds WebRTC.DesktopCapture.Win.DirectXCursorEmbedded UMA

Browse Source 
Logs if the mouse cursor has moved and if so if it is embedded in the
captured DXGI frame or not.

Bug: chromium:1421656
Change-Id: Ic8fa8a5a3c020ec28b04064c765b1c204accec1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298564
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#39644}
This commit is contained in:
henrika 2023-03-22 10:49:20 +01:00 committed by WebRTC LUCI CQ
parent b17957ac52
commit 6bdb285e21
2 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
modules/desktop_capture/win/dxgi_output_duplicator.cc
View File

@ -25,6 +25,7 @@
#include "rtc_base/logging.h"
#include "rtc_base/string_utils.h"
#include "rtc_base/win32.h"
#include "system_wrappers/include/metrics.h"
namespace webrtc {
@ -146,6 +147,30 @@ bool DxgiOutputDuplicator::ReleaseFrame() {
return true;
}
void DxgiOutputDuplicator::LogMouseCursor(
const DXGI_OUTDUPL_FRAME_INFO& frame_info) {
// Ignore cases when the mouse shape has changed and not the position.
const bool new_pointer_shape = (frame_info.PointerShapeBufferSize != 0);
if (new_pointer_shape)
return;
// The mouse cursor has moved and we can now query if the mouse pointer is
// drawn onto the desktop image or not to decide if we must draw the mouse
// pointer shape onto the desktop image (always done by default currently).
// Either the mouse pointer is already drawn onto the desktop image that
// IDXGIOutputDuplication::AcquireNextFrame provides or the mouse pointer is
// separate from the desktop image. If the mouse pointer is drawn onto the
// desktop image, the pointer position data that is reported by
// AcquireNextFrame indicates that a separate pointer isn’t visible, hence
// `frame_info.PointerPosition.Visible` is false.
// TODO(http://crbug.com/1421656): evaluate this UMA and possibly call
// set_may_contain_cursor(cursor_embedded_in_frame) on the captured frame to
// avoid rendering the cursor twice.
const bool cursor_embedded_in_frame = !frame_info.PointerPosition.Visible;
RTC_HISTOGRAM_BOOLEAN("WebRTC.DesktopCapture.Win.DirectXCursorEmbedded",
cursor_embedded_in_frame);
}
bool DxgiOutputDuplicator::Duplicate(Context* context,
DesktopVector offset,
SharedDesktopFrame* target) {
@ -169,6 +194,13 @@ bool DxgiOutputDuplicator::Duplicate(Context* context,
return false;
}
// The DXGI_OUTDUPL_POINTER_POSITION structure that describes the most recent
// mouse position is only valid if the LastMouseUpdateTime member is a non-
// zero value.
if (frame_info.LastMouseUpdateTime.QuadPart != 0) {
LogMouseCursor(frame_info);
}
// We need to merge updated region with the one from context, but only spread
// updated region from current frame. So keeps a copy of updated region from
// context here. The `updated_region` always starts from (0, 0).

5
modules/desktop_capture/win/dxgi_output_duplicator.h
View File

@ -97,6 +97,11 @@ class DxgiOutputDuplicator {
bool DoDetectUpdatedRegion(const DXGI_OUTDUPL_FRAME_INFO& frame_info,
DesktopRegion* updated_region);
// Adds boolean WebRTC.DesktopCapture.Win.DirectXCursorEmbedded UMA stat which
// contains true if the mouse cursor is embedded in the captured frame and
// false if not.
void LogMouseCursor(const DXGI_OUTDUPL_FRAME_INFO& frame_info);
bool ReleaseFrame();
// Initializes duplication_ instance. Expects duplication_ is in empty status.