From 6ba7feb302b478d13a586e3a35b6ecb28dd9977e Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Wed, 13 Sep 2023 09:54:49 +0200 Subject: [PATCH] Make video encoder reconfiguration logging more verbose MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit logging the configuration, in particular the content type which together with RTP configuration information like the ssrcs helps differentiating between encoders. BUG=None Change-Id: I1b4b2ec2bffea338cc73c3a9c6a3f775d8f1c26b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/319560 Reviewed-by: Henrik Boström Reviewed-by: Ilya Nikolaevskiy Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/main@{#40744} --- video/config/video_encoder_config.cc | 3 +-- video/video_send_stream.cc | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/video/config/video_encoder_config.cc b/video/config/video_encoder_config.cc index 5eec7b5f78..84442aeddf 100644 --- a/video/config/video_encoder_config.cc +++ b/video/config/video_encoder_config.cc @@ -68,8 +68,7 @@ VideoEncoderConfig::~VideoEncoderConfig() = default; std::string VideoEncoderConfig::ToString() const { char buf[1024]; rtc::SimpleStringBuilder ss(buf); - ss << "{codec_type: "; - ss << CodecTypeToPayloadString(codec_type); + ss << "{codec_type: " << CodecTypeToPayloadString(codec_type); ss << ", content_type: "; switch (content_type) { case ContentType::kRealtimeVideo: diff --git a/video/video_send_stream.cc b/video/video_send_stream.cc index a01c1004a3..571eb62c6b 100644 --- a/video/video_send_stream.cc +++ b/video/video_send_stream.cc @@ -282,6 +282,8 @@ void VideoSendStream::ReconfigureVideoEncoder(VideoEncoderConfig config, SetParametersCallback callback) { RTC_DCHECK_RUN_ON(&thread_checker_); RTC_DCHECK_EQ(content_type_, config.content_type); + RTC_LOG(LS_VERBOSE) << "Encoder config: " << config.ToString() + << " VideoSendStream config: " << config_.ToString(); video_stream_encoder_->ConfigureEncoder( std::move(config), config_.rtp.max_packet_size - CalculateMaxHeaderSize(config_.rtp),