admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused 'last_rtt_ms_' variable from vcm::VideoStreamDecoder.

Browse Source 
The effect of this is one less lock being grabbed when updating rtt stats.

(Using NoTry=True since the mac_asan and mac_rel bots are acting up)

Bug: None
Change-Id: I7dac4031573aa54550068a7039e5c2d3054cb50b
NoTry: true
Reviewed-on: https://webrtc-review.googlesource.com/64522
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22593}
This commit is contained in:
Tommi 2018-03-25 19:52:46 +02:00 committed by Commit Bot
parent b0ba558c96
commit 6b28e20257
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
video/video_stream_decoder.cc
View File

@ -35,8 +35,7 @@ VideoStreamDecoder::VideoStreamDecoder(
rtc::VideoSinkInterface<VideoFrame>* incoming_video_stream)
: video_receiver_(video_receiver),
receive_stats_callback_(receive_statistics_proxy),
incoming_video_stream_(incoming_video_stream),
last_rtt_ms_(0) {
incoming_video_stream_(incoming_video_stream) {
RTC_DCHECK(video_receiver_);
static const int kMaxPacketAgeToNack = 450;
@ -128,8 +127,5 @@ void VideoStreamDecoder::OnCompleteFrame(bool is_keyframe,
void VideoStreamDecoder::OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms) {
video_receiver_->SetReceiveChannelParameters(max_rtt_ms);
rtc::CritScope lock(&crit_);
last_rtt_ms_ = avg_rtt_ms;
}
} // namespace webrtc

2
video/video_stream_decoder.h
View File

@ -96,8 +96,6 @@ class VideoStreamDecoder : public VCMReceiveCallback,
ReceiveStatisticsProxy* const receive_stats_callback_;
rtc::VideoSinkInterface<VideoFrame>* const incoming_video_stream_;
int64_t last_rtt_ms_ RTC_GUARDED_BY(crit_);
};
} // namespace webrtc