admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove uses of #pragma once and add PRESUBMIT check.

Browse Source 
They violate the C++ coding style guide:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#File-headers

BUG=webrtc:7191
NOTRY=True

Review-Url: https://codereview.webrtc.org/2707843002
Cr-Commit-Position: refs/heads/master@{#16712}
This commit is contained in:
kjellander 2017-02-20 01:13:18 -08:00 committed by Commit bot
parent fe5d521a69
commit 6aeef74b6e
9 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
PRESUBMIT.py
View File

@ -169,6 +169,26 @@ def _CheckNoIOStreamInHeaders(input_api, output_api):
return []
def _CheckNoPragmaOnce(input_api, output_api):
"""Make sure that banned functions are not used."""
files = []
pattern = input_api.re.compile(r'^#pragma\s+once',
input_api.re.MULTILINE)
for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
if not f.LocalPath().endswith('.h'):
continue
contents = input_api.ReadFile(f)
if pattern.search(contents):
files.append(f)
if files:
return [output_api.PresubmitError(
'Do not use #pragma once in header files.\n'
'See http://www.chromium.org/developers/coding-style#TOC-File-headers',
files)]
return []
def _CheckNoFRIEND_TEST(input_api, output_api):
"""Make sure that gtest's FRIEND_TEST() macro is not used, the
FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be
@ -514,6 +534,7 @@ def _CommonChecks(input_api, output_api):
input_api, output_api))
results.extend(_CheckNativeApiHeaderChanges(input_api, output_api))
results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
results.extend(_CheckNoPragmaOnce(input_api, output_api))
results.extend(_CheckNoFRIEND_TEST(input_api, output_api))
results.extend(_CheckGnChanges(input_api, output_api))
results.extend(_CheckUnwantedDependencies(input_api, output_api))

1
webrtc/examples/peerconnection/client/conductor.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_CONDUCTOR_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_CONDUCTOR_H_
#pragma once
#include <deque>
#include <map>

1
webrtc/examples/peerconnection/client/defaults.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_DEFAULTS_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_DEFAULTS_H_
#pragma once
#include <stdint.h>

1
webrtc/examples/peerconnection/client/flagdefs.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_FLAGDEFS_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_FLAGDEFS_H_
#pragma once
#include "webrtc/base/flags.h"

1
webrtc/examples/peerconnection/client/main_wnd.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_MAIN_WND_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_MAIN_WND_H_
#pragma once
#include <map>
#include <memory>

1
webrtc/examples/peerconnection/client/peer_connection_client.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_PEER_CONNECTION_CLIENT_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_CLIENT_PEER_CONNECTION_CLIENT_H_
#pragma once
#include <map>
#include <memory>

1
webrtc/examples/peerconnection/server/data_socket.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_SERVER_DATA_SOCKET_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_SERVER_DATA_SOCKET_H_
#pragma once
#ifdef WIN32
#include <winsock2.h>

1
webrtc/examples/peerconnection/server/peer_channel.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_SERVER_PEER_CHANNEL_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_SERVER_PEER_CHANNEL_H_
#pragma once
#include <time.h>

1
webrtc/examples/peerconnection/server/utils.h
View File

@ -10,7 +10,6 @@
#ifndef WEBRTC_EXAMPLES_PEERCONNECTION_SERVER_UTILS_H_
#define WEBRTC_EXAMPLES_PEERCONNECTION_SERVER_UTILS_H_
#pragma once
#include <assert.h>
#include <string>