From 6abb750993460cb181dc78b454f1a1d6910b4444 Mon Sep 17 00:00:00 2001 From: "wu@webrtc.org" Date: Thu, 1 Aug 2013 18:00:02 +0000 Subject: [PATCH] Delete gtest_exclude for asan which doesn't have effect with how the bots are setup now Add gtest_exclude for tsan to disable some flakey tests. Change tsan suppression since the function name has been changed from DecodeWithErrors to DecodeErrorMode. TBR=mallinath Review URL: https://webrtc-codereview.appspot.com/1930004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4465 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../libjingle_p2p_unittest.gtest-asan.txt | 1 - .../libjingle_p2p_unittest.gtest-tsan.txt | 2 ++ tools/valgrind-webrtc/tsan/suppressions.txt | 20 +++++++++---------- 3 files changed, 12 insertions(+), 11 deletions(-) delete mode 100644 tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-asan.txt create mode 100644 tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-asan.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-asan.txt deleted file mode 100644 index 958996ae50..0000000000 --- a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-asan.txt +++ /dev/null @@ -1 +0,0 @@ -VideoChannelTest.TestScreencastEvents diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt new file mode 100644 index 0000000000..ffbcd4a91f --- /dev/null +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt @@ -0,0 +1,2 @@ +P2PTransportChannelTest.TestOPENToNAT_FULL_CONEAsGiceNoneSharedUfrag +PortTest.TestSendStunMessageAsIce diff --git a/tools/valgrind-webrtc/tsan/suppressions.txt b/tools/valgrind-webrtc/tsan/suppressions.txt index 7c0736d84e..1ee8c2b772 100644 --- a/tools/valgrind-webrtc/tsan/suppressions.txt +++ b/tools/valgrind-webrtc/tsan/suppressions.txt @@ -197,16 +197,6 @@ fun:webrtc::ModuleRtpRtcpImpl::~ModuleRtpRtcpImpl ... } -{ - bug_1205_17 - ThreadSanitizer:Race - fun:webrtc::VCMJitterBuffer::DecodeWithErrors - fun:webrtc::VCMReceiver::SetDecodeWithErrors - fun:webrtc::VideoCodingModuleImpl::SetVideoProtection - fun:webrtc::ViEChannel::SetHybridNACKFECStatus - fun:webrtc::ViERTP_RTCPImpl::SetHybridNACKFECStatus - ... -} { bug_1205_18 ThreadSanitizer:Race @@ -455,6 +445,16 @@ fun:webrtc::VoEBaseImpl::StopPlayout ... } +{ + bug_1205_44 + ThreadSanitizer:Race + fun:webrtc::VCMJitterBuffer::DecodeErrorMode + fun:webrtc::VCMReceiver::SetDecodeErrorMode + fun:webrtc::VideoCodingModuleImpl::SetVideoProtection + fun:webrtc::ViEChannel::SetHybridNACKFECStatus + fun:webrtc::ViERTP_RTCPImpl::SetHybridNACKFECStatus + ... +} { bug_2078_1 ThreadSanitizer:Race