From 69807e8871cc51a76995d65ef712caa840450673 Mon Sep 17 00:00:00 2001 From: Yves Gerey Date: Tue, 30 Oct 2018 22:23:02 +0100 Subject: [PATCH] Depend directly on destination targets. Makes 'gn check' happy. Followup to https://webrtc-review.googlesource.com/c/src/+/106820 Bug: webrtc:5876, webrtc:9855 Change-Id: I33fa2c31ba26dc10c9a9c17da0ffed255c1f4d5b Reviewed-on: https://webrtc-review.googlesource.com/c/108760 Commit-Queue: Yves Gerey Reviewed-by: Karl Wiberg Reviewed-by: Niels Moller Cr-Commit-Position: refs/heads/master@{#25447} --- call/BUILD.gn | 1 + logging/BUILD.gn | 1 + media/BUILD.gn | 2 ++ modules/audio_coding/BUILD.gn | 2 ++ pc/BUILD.gn | 1 + 5 files changed, 7 insertions(+) diff --git a/call/BUILD.gn b/call/BUILD.gn index 6d2ea8204f..21d1ac1c94 100644 --- a/call/BUILD.gn +++ b/call/BUILD.gn @@ -362,6 +362,7 @@ if (rtc_include_tests) { "//testing/gmock", "//testing/gtest", "//third_party/abseil-cpp/absl/memory", + "//third_party/abseil-cpp/absl/types:optional", ] if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). diff --git a/logging/BUILD.gn b/logging/BUILD.gn index f22f61253a..27977d34ca 100644 --- a/logging/BUILD.gn +++ b/logging/BUILD.gn @@ -352,6 +352,7 @@ if (rtc_enable_protobuf) { "../test:test_support", "//testing/gtest", "//third_party/abseil-cpp/absl/memory", + "//third_party/abseil-cpp/absl/types:optional", ] if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). diff --git a/media/BUILD.gn b/media/BUILD.gn index cc48b069ad..8eaa23ce02 100644 --- a/media/BUILD.gn +++ b/media/BUILD.gn @@ -455,6 +455,7 @@ if (rtc_include_tests) { "../rtc_base:rtc_task_queue", "../rtc_base:stringutils", "//third_party/abseil-cpp/absl/memory", + "//third_party/abseil-cpp/absl/strings", ] sources = [ "base/fakeframesource.cc", @@ -551,6 +552,7 @@ if (rtc_include_tests) { "../rtc_base:stringutils", "../test:field_trial", "//third_party/abseil-cpp/absl/memory", + "//third_party/abseil-cpp/absl/strings", ] sources = [ "base/codec_unittest.cc", diff --git a/modules/audio_coding/BUILD.gn b/modules/audio_coding/BUILD.gn index 455dcd0c9e..6a630e0889 100644 --- a/modules/audio_coding/BUILD.gn +++ b/modules/audio_coding/BUILD.gn @@ -1437,6 +1437,7 @@ if (rtc_include_tests) { ":neteq_tools", "../../rtc_base:rtc_base_approved", "../../test:test_support", + "//third_party/abseil-cpp/absl/strings", "//testing/gtest", ] } @@ -2123,6 +2124,7 @@ if (rtc_include_tests) { "codecs/opus/test:test_unittest", "//testing/gtest", "//third_party/abseil-cpp/absl/memory", + "//third_party/abseil-cpp/absl/types:optional", ] defines = audio_coding_defines diff --git a/pc/BUILD.gn b/pc/BUILD.gn index bdbcb38964..7663f8b2f2 100644 --- a/pc/BUILD.gn +++ b/pc/BUILD.gn @@ -509,6 +509,7 @@ if (rtc_include_tests) { "../system_wrappers:metrics", "../test:fileutils", "//third_party/abseil-cpp/absl/memory", + "//third_party/abseil-cpp/absl/strings", ] if (is_android) { deps += [ ":android_black_magic" ]