From 692f3c70e4da8b8d0fb55463e10f6ef8821d8fc4 Mon Sep 17 00:00:00 2001 From: Steve Anton Date: Thu, 16 Jan 2020 14:12:31 -0800 Subject: [PATCH] Explicitly wait for ICE to complete in VerifyBestConnection Bug: webrtc:11281 Change-Id: I94eeac3e08c1a2abc9057c5dad648e987f049c97 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166402 Reviewed-by: Qingsi Wang Commit-Queue: Steve Anton Cr-Commit-Position: refs/heads/master@{#30290} --- pc/peer_connection_integrationtest.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pc/peer_connection_integrationtest.cc b/pc/peer_connection_integrationtest.cc index ad1181c4a3..ee60ea4853 100644 --- a/pc/peer_connection_integrationtest.cc +++ b/pc/peer_connection_integrationtest.cc @@ -4591,6 +4591,10 @@ TEST_P(PeerConnectionIntegrationIceStatesTest, VerifyBestConnection) { caller()->CreateAndSetAndSignalOffer(); ASSERT_TRUE_WAIT(SignalingStateStable(), kDefaultTimeout); + EXPECT_EQ_WAIT(webrtc::PeerConnectionInterface::kIceConnectionCompleted, + caller()->ice_connection_state(), kDefaultTimeout); + EXPECT_EQ_WAIT(webrtc::PeerConnectionInterface::kIceConnectionConnected, + callee()->ice_connection_state(), kDefaultTimeout); // TODO(bugs.webrtc.org/9456): Fix it. const int num_best_ipv4 = webrtc::metrics::NumEvents(