From 692409f8e7576ebb46f0f63e45c7a9c34dfe64ce Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Thu, 19 Jul 2018 09:20:53 +0200 Subject: [PATCH] Enabling clang::find_bad_constructs in modules/BUILD.gn. This CL removes //build/config/clang:find_bad_constructs from the suppressed_configs list, which means that clang:find_bad_constructs is now enabled on these translation units. Bug: webrtc:9251, webrtc:163 Change-Id: I4d5e8476dca16030814a01447b1d8522f0105b2a Reviewed-on: https://webrtc-review.googlesource.com/89580 Reviewed-by: Oleh Prypin Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#24038} --- modules/BUILD.gn | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/modules/BUILD.gn b/modules/BUILD.gn index 035df66fe6..0109cf219d 100644 --- a/modules/BUILD.gn +++ b/modules/BUILD.gn @@ -120,11 +120,6 @@ if (rtc_include_tests) { if (is_ios) { deps += [ ":modules_tests_bundle_data" ] } - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } modules_unittests_resources = [ @@ -245,11 +240,6 @@ if (rtc_include_tests) { "module_common_types_unittest.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ ":module_api", "../test:test_main",