From 68831d28c7be9d88d207999e52cc33f174e30a27 Mon Sep 17 00:00:00 2001 From: Joachim Reiersen Date: Wed, 7 Feb 2024 11:14:47 -0800 Subject: [PATCH] Remove extraneous partial re-initialization of NetEq in the ChannelReceive ctor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These function calls break RAII and are redundant since NetEq and voe::AudioLevel have just been constructed. Remove them to fix an issue where NetEq ignores the min/max delay passed to its constructor. This will not change default behavior since the defaults in NetEq::Config for max_delay_ms and min_delay_ms are both 0. Bug: webrtc:15835 Change-Id: I27d4745ac85d6c6948796fe1d6286a0b79429474 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338209 Reviewed-by: Jakob Ivarsson‎ Commit-Queue: Jakob Ivarsson‎ Cr-Commit-Position: refs/heads/main@{#41694} --- audio/channel_receive.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/audio/channel_receive.cc b/audio/channel_receive.cc index 8367b00113..17cf859ed8 100644 --- a/audio/channel_receive.cc +++ b/audio/channel_receive.cc @@ -569,13 +569,6 @@ ChannelReceive::ChannelReceive( network_thread_checker_.Detach(); - acm_receiver_.ResetInitialDelay(); - acm_receiver_.SetMinimumDelay(0); - acm_receiver_.SetMaximumDelay(0); - acm_receiver_.FlushBuffers(); - - _outputAudioLevel.ResetLevelFullRange(); - rtp_receive_statistics_->EnableRetransmitDetection(remote_ssrc_, true); RtpRtcpInterface::Configuration configuration; configuration.clock = clock;