From 682755e49e786d230b23f49f1df157656b8a45b9 Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Mon, 22 May 2023 11:57:14 +0200 Subject: [PATCH] Do not support frame tracking id extension in production Pushing it to the list of extensions to negotiate could result in enabling it in production. BUG=None Change-Id: I98599e9fbac7e2b81b3f2ad0c7759bb052d9d9d1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306101 Commit-Queue: Philipp Hancke Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#40250} --- media/engine/webrtc_video_engine.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/media/engine/webrtc_video_engine.cc b/media/engine/webrtc_video_engine.cc index 971cee3e94..1637451b53 100644 --- a/media/engine/webrtc_video_engine.cc +++ b/media/engine/webrtc_video_engine.cc @@ -912,12 +912,11 @@ WebRtcVideoEngine::GetRtpHeaderExtensions() const { ? webrtc::RtpTransceiverDirection::kSendRecv : webrtc::RtpTransceiverDirection::kStopped); - result.emplace_back( - webrtc::RtpExtension::kVideoFrameTrackingIdUri, id++, - IsEnabled(trials_, "WebRTC-VideoFrameTrackingIdAdvertised") - ? webrtc::RtpTransceiverDirection::kSendRecv - : webrtc::RtpTransceiverDirection::kStopped); - + // VideoFrameTrackingId is a test-only extension. + if (IsEnabled(trials_, "WebRTC-VideoFrameTrackingIdAdvertised")) { + result.emplace_back(webrtc::RtpExtension::kVideoFrameTrackingIdUri, id++, + webrtc::RtpTransceiverDirection::kSendRecv); + } return result; }