From 678cf29d8b97e72a3748f24720ddf4852a0ae9ab Mon Sep 17 00:00:00 2001 From: "fischman@webrtc.org" Date: Tue, 23 Jul 2013 18:32:10 +0000 Subject: [PATCH] webrtc/common_types.h: Document bitrate fields' units. R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/1847004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4386 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/common_types.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/webrtc/common_types.h b/webrtc/common_types.h index 525dcf9b86..3a5b7f3dda 100644 --- a/webrtc/common_types.h +++ b/webrtc/common_types.h @@ -227,7 +227,7 @@ struct CodecInst int plfreq; int pacsize; int channels; - int rate; + int rate; // bits/sec unlike {start,min,max}Bitrate elsewhere in this file! }; enum FrameType @@ -525,9 +525,9 @@ struct SimulcastStream unsigned short width; unsigned short height; unsigned char numberOfTemporalLayers; - unsigned int maxBitrate; - unsigned int targetBitrate; - unsigned int minBitrate; + unsigned int maxBitrate; // kilobits/sec. + unsigned int targetBitrate; // kilobits/sec. + unsigned int minBitrate; // kilobits/sec. unsigned int qpMax; // minimum quality }; @@ -546,9 +546,9 @@ struct VideoCodec unsigned short width; unsigned short height; - unsigned int startBitrate; - unsigned int maxBitrate; - unsigned int minBitrate; + unsigned int startBitrate; // kilobits/sec. + unsigned int maxBitrate; // kilobits/sec. + unsigned int minBitrate; // kilobits/sec. unsigned char maxFramerate; VideoCodecUnion codecSpecific;