admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete old "metronome" name, API users should use "decode_metronome".

Browse Source 
Now that Chromium has migrated to the new name[1], "decode_metronome",
we can delete the variable with the old name, "metronome".

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5093942

Bug: webrtc:15704
Change-Id: I50fef88a692d83e37af10956b2e12389fa601662
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330300
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41331}
This commit is contained in:
Henrik Boström 2023-12-06 16:35:17 +01:00 committed by WebRTC LUCI CQ
parent 9384c9ea66
commit 65bee96054
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
api/peer_connection_interface.h
View File

@ -1443,10 +1443,6 @@ struct RTC_EXPORT PeerConnectionFactoryDependencies final {
transport_controller_send_factory; transport_controller_send_factory;
// Metronome used for decoding, must be called on the worker thread. // Metronome used for decoding, must be called on the worker thread.
std::unique_ptr<Metronome> decode_metronome; std::unique_ptr<Metronome> decode_metronome;
// Old name for `decode_metronome`.
// TODO(https://crbug.com/webrtc/15704): When callers have migrated to
// `decode_metronome`, delete this.
std::unique_ptr<Metronome> metronome;
// Media specific dependencies. Unused when `media_factory == nullptr`. // Media specific dependencies. Unused when `media_factory == nullptr`.
rtc::scoped_refptr<AudioDeviceModule> adm; rtc::scoped_refptr<AudioDeviceModule> adm;

4
pc/peer_connection_factory.cc
View File

@ -103,9 +103,7 @@ PeerConnectionFactory::PeerConnectionFactory(
(dependencies->transport_controller_send_factory) (dependencies->transport_controller_send_factory)
? std::move(dependencies->transport_controller_send_factory) ? std::move(dependencies->transport_controller_send_factory)
: std::make_unique<RtpTransportControllerSendFactory>()), : std::make_unique<RtpTransportControllerSendFactory>()),
decode_metronome_(dependencies->decode_metronome decode_metronome_(std::move(dependencies->decode_metronome)) {}
? std::move(dependencies->decode_metronome)
: std::move(dependencies->metronome)) {}
PeerConnectionFactory::PeerConnectionFactory( PeerConnectionFactory::PeerConnectionFactory(
PeerConnectionFactoryDependencies dependencies) PeerConnectionFactoryDependencies dependencies)