From 65b46da1f828b655a169e63ecdc886814d4b8945 Mon Sep 17 00:00:00 2001 From: Victor Boivie Date: Fri, 6 Sep 2024 12:40:49 +0200 Subject: [PATCH] dcsctp: Don't send FORWARD-TSN in its own chunk This is a rollback of a change list [1] that was an attempt to avoid a bug in usrsctp[2], but it wasn't very successful. But with the usrsctp bug fixed, we can revert to the desired state; that we bundle FORWARD-TSN with other control and data chunks in a SCTP packet. [1] https://webrtc-review.googlesource.com/c/src/+/229101 [2] https://github.com/sctplab/usrsctp/issues/597 Bug: webrtc:42223134 Change-Id: I2f3b511c91639e6b9516160190600beb0c04b5fa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361862 Reviewed-by: Florent Castelli Commit-Queue: Victor Boivie Cr-Commit-Position: refs/heads/main@{#42976} --- net/dcsctp/socket/transmission_control_block.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/net/dcsctp/socket/transmission_control_block.cc b/net/dcsctp/socket/transmission_control_block.cc index 26ca6f66ee..38913e6257 100644 --- a/net/dcsctp/socket/transmission_control_block.cc +++ b/net/dcsctp/socket/transmission_control_block.cc @@ -169,7 +169,6 @@ void TransmissionControlBlock::MaybeSendForwardTsn(SctpPacket::Builder& builder, } else { builder.Add(retransmission_queue_.CreateForwardTsn()); } - Send(builder); // https://datatracker.ietf.org/doc/html/rfc3758 // "IMPLEMENTATION NOTE: An implementation may wish to limit the number of // duplicate FORWARD TSN chunks it sends by ... waiting a full RTT before